Skip to content

docs: sync tls.crl_file into duplicated TLS tables - #2722

Open
eschabell wants to merge 1 commit into
fluent:masterfrom
eschabell:erics_docs_tsl_sync_updates
Open

eschabell wants to merge 1 commit into
fluent:masterfrom
eschabell:erics_docs_tsl_sync_updates

Conversation

@eschabell

@eschabell eschabell commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator
  • Add tls.crl_file to the TLS property tables on s3, opentelemetry
    (input and output), azure_kusto, forward, and tcp-and-tls, using the
    canonical wording from administration/transport-security.md
  • Sync the reserved config key list for Go output plugins with the
    properties flb_output.c actually reserves, adding tls.ciphers,
    tls.crl_file, tls.max_version, tls.min_version, the tls.proxy.*
    family, tls.verify_hostname, and the tls.windows.* family

Signed-off-by: Eric D. Schabell eric@schabell.org

Summary by CodeRabbit

  • Documentation
    • Documented the tls.crl_file setting across OpenTelemetry, Azure Kusto, Secure Forward, S3, TCP, and TLS integrations.
    • Clarified that PEM-formatted Certificate Revocation Lists can be used during TLS verification to reject revoked certificates.
    • Documented additional reserved TLS configuration keys for custom plugins, including certificate stores, verification, proxy, and protocol version settings.

  - Add tls.crl_file to the TLS property tables on s3, opentelemetry
    (input and output), azure_kusto, forward, and tcp-and-tls, using the
    canonical wording from administration/transport-security.md
  - Sync the reserved config key list for Go output plugins with the
    properties flb_output.c actually reserves, adding tls.ciphers,
    tls.crl_file, tls.max_version, tls.min_version, the tls.proxy.*
    family, tls.verify_hostname, and the tls.windows.* family

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell
eschabell requested review from a team and patrick-stephens as code owners September 20, 2026 18:20
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 68d5decf-76e5-4956-a96b-b63e9a440b1e

📥 Commits

Reviewing files that changed from the base of the PR and between 95a70d5 and 3e6129b.

📒 Files selected for processing (7)
  • development/golang-output-plugins.md
  • pipeline/inputs/opentelemetry.md
  • pipeline/outputs/azure_kusto.md
  • pipeline/outputs/forward.md
  • pipeline/outputs/opentelemetry.md
  • pipeline/outputs/s3.md
  • pipeline/outputs/tcp-and-tls.md

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Changes

TLS CRL documentation

Layer / File(s) Summary
TLS CRL configuration documentation
development/golang-output-plugins.md, pipeline/inputs/opentelemetry.md, pipeline/outputs/*.md
The reserved custom-plugin key list includes additional TLS keys. OpenTelemetry, Azure Kusto, Secure Forward, S3, and TCP/TLS documentation now describes tls.crl_file and its TLS verification behavior.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main documentation change: adding tls.crl_file to duplicated TLS configuration tables. It does not mention the additional reserved-key synchronization, but the title …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eschabell eschabell self-assigned this Sep 20, 2026
@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 5.1.3 labels Sep 20, 2026
@eschabell

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@eschabell

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@eschabell

Copy link
Copy Markdown
Collaborator Author

@patrick-stephens ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.1.3 waiting-on-review Waiting on a review from mainteners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant