-
Notifications
You must be signed in to change notification settings - Fork 543
aws-credentials: add AWS Greengrass endpoint details #2323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThis pull request adds a navigation entry and a new "AWS Greengrass credentials" section to the AWS credentials documentation, explaining how to retrieve credentials from the local Greengrass token exchange service and which environment variables are used. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-12-12T14:30:18.461ZApplied to files:
🔇 Additional comments (2)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For technical perspective, it looks good to me.
|
As for the Lint PRs tooling - https://github.com/fluent/fluent-bit-docs/actions/runs/21009761247/job/60425402810?pr=2323 I've seen it as AWS Greengrass, AWS IOT Greengrass, and Greengrass - so the spelling should not be an issue. |
alexakreizinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShelbyZ thanks for the PR! (and feel free to ignore our linter for the "Greengrass" flag; it uses a pretty strict dictionary, so we'll have to add that to its allowlist later 😆)
I added one small suggestion, but otherwise LGTM :)
Signed-off-by: Shelby Hagman <shelbyzh@amazon.com>
28c57c8 to
c9396e4
Compare
Add documentation for support of AWS Greengrass endpoint
Related: fluent/fluent-bit#11369
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.