in_opentelemetry: fix typo and sort configuration parameters #2298

eschabell · 2025-12-12T15:48:36Z

Fix typo: log_supress_interval → log_suppress_interval
Sort configuration parameters alphabetically:
- buffer_chunk_size before buffer_max_size
- thread.ring_buffer.* before threaded
- tls.ciphers before tls.crt_file

Applies to #2209.

Summary by CodeRabbit

Documentation
- Updated OpenTelemetry input plugin documentation to reflect correct configuration parameter naming conventions and ensure consistency and accuracy throughout all reference materials.
- Improved overall documentation formatting and structure to enhance visual clarity and make it easier for users to understand and properly implement the plugin configuration.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…ically - Fix typo: log_supress_interval → log_suppress_interval - Sort configuration parameters alphabetically: - buffer_chunk_size before buffer_max_size - thread.ring_buffer.* before threaded - tls.ciphers before tls.crt_file Applies to fluent#2209. Signed-off-by: Eric D. Schabell <eric@schabell.org>

coderabbitai · 2025-12-12T15:48:46Z

Walkthrough

The pull request corrects a typo in OpenTelemetry input plugin documentation by renaming the configuration key log_supress_interval to log_suppress_interval. Minor formatting adjustments accompany the change.

Changes

Cohort / File(s)	Summary
Documentation typo fix `pipeline/inputs/opentelemetry.md`	Renamed configuration key `log_supress_interval` to `log_suppress_interval` (spelling correction) and adjusted formatting around related configuration options

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Single file change limited to documentation
Straightforward typo correction with no semantic impact
No functional logic or control flow implications

Possibly related PRs

Updated and fixed opentelemetry input plugin options configuration table. Fixes #2152. #2153: Directly overlaps by correcting the same typo in the OpenTelemetry configuration key from log_supress_interval to log_suppress_interval.

Suggested reviewers

alexakreizinger
esmerel

Poem

🐰 A hop through the docs, a typo caught clear,
"Suppress" spells right—the fix brings good cheer,
One letter stood wrong, now tidy and true,
Attention to detail, that's what we do! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes both main changes: fixing a typo (log_suppress_interval) and sorting configuration parameters in the OpenTelemetry input plugin documentation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

eschabell · 2025-12-12T15:48:59Z

@alexakreizinger a new PR with some changes for your review.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d31204 and 8cd1777.

📒 Files selected for processing (1)

pipeline/inputs/opentelemetry.md (2 hunks)

🔇 Additional comments (3)

pipeline/inputs/opentelemetry.md (3)

16-18: Keep key ordering consistent: buffer_chunk_size should remain before buffer_max_size.

This section looks correct as shown (and matches the PR objective).

43-46: Threading options ordering matches the stated convention.

Placing thread.ring_buffer.* before threaded improves scanability and matches the PR objective.

49-51: TLS keys ordering matches the stated convention (tls.ciphers before tls.crt_file).

Looks consistent with the sorting objective.

pipeline/inputs/opentelemetry.md

patrick-stephens · 2025-12-12T16:02:48Z

pipeline/inputs/opentelemetry.md

-| `threaded`                          | Enable threading on an input.                                                                                                                                                                 | `false`     |
 | `thread.ring_buffer.capacity`       | Set custom ring buffer capacity when the input runs in threaded mode.                                                                                                                         | `1024`      |
 | `thread.ring_buffer.window`         | Set custom ring buffer window percentage for threaded inputs.                                                                                                                                 | `5`         |
+| `threaded`                          | Enable threading on an input.                                                                                                                                                                 | `false`     |


I'd probably link out to what this means somewhere.

maybe this doc? https://docs.fluentbit.io/manual/administration/multithreading

alexakreizinger · 2025-12-12T20:27:08Z

pipeline/inputs/opentelemetry.md

 | `listen`                            | The network address to listen on.                                                                                                                                                             | `0.0.0.0`   |
 | `log_level`                         | Specifies the log level for this plugin. If not set here, the plugin uses the global log level specified in the `service` section of your configuration file.                                 | `info`      |
-| `log_supress_interval`              | Suppresses log messages from this plugin that appear similar within a specified time interval. `0` no suppression.                                                                            | `0`         |
+| `log_suppress_interval`             | Suppresses log messages from this plugin that appear similar within a specified time interval. `0` no suppression.                                                                            | `0`         |


Suggested change

| `log_suppress_interval` | Suppresses log messages from this plugin that appear similar within a specified time interval. `0` no suppression. | `0` |

| `log_suppress_interval` | Suppresses similar log messages from this plugin that appear within a specified time interval. A value of `0` sets no suppression. | `0` |

alexakreizinger · 2025-12-12T20:29:26Z

pipeline/inputs/opentelemetry.md

-| `threaded`                          | Enable threading on an input.                                                                                                                                                                 | `false`     |
 | `thread.ring_buffer.capacity`       | Set custom ring buffer capacity when the input runs in threaded mode.                                                                                                                         | `1024`      |
 | `thread.ring_buffer.window`         | Set custom ring buffer window percentage for threaded inputs.                                                                                                                                 | `5`         |
+| `threaded`                          | Enable threading on an input.                                                                                                                                                                 | `false`     |


alexakreizinger

added a few suggestions, but pending those LGTM!

eschabell requested a review from alexakreizinger December 12, 2025 15:48

eschabell self-assigned this Dec 12, 2025

eschabell requested review from a team as code owners December 12, 2025 15:48

eschabell added waiting-on-review Waiting on a review from mainteners 4.2.1 labels Dec 12, 2025

eschabell added 4.2 and removed 4.2.1 labels Dec 12, 2025

coderabbitai bot reviewed Dec 12, 2025

View reviewed changes

pipeline/inputs/opentelemetry.md Show resolved Hide resolved

patrick-stephens reviewed Dec 12, 2025

View reviewed changes

alexakreizinger reviewed Dec 12, 2025

View reviewed changes

alexakreizinger approved these changes Dec 12, 2025

View reviewed changes

cosmo0920 approved these changes Dec 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

in_opentelemetry: fix typo and sort configuration parameters #2298

in_opentelemetry: fix typo and sort configuration parameters #2298

Uh oh!

eschabell commented Dec 12, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

eschabell commented Dec 12, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

patrick-stephens Dec 12, 2025

Uh oh!

alexakreizinger Dec 12, 2025

Uh oh!

alexakreizinger Dec 12, 2025

Uh oh!

alexakreizinger Dec 12, 2025

Uh oh!

alexakreizinger left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	\| `log_suppress_interval` \| Suppresses log messages from this plugin that appear similar within a specified time interval. `0` no suppression. \| `0` \|
	\| `log_suppress_interval` \| Suppresses similar log messages from this plugin that appear within a specified time interval. A value of `0` sets no suppression. \| `0` \|

	\| `threaded` \| Enable threading on an input. \| `false` \|
	\| `threaded` \| Indicates whether to run this input in its own [thread](../../administration/multithreading.md#inputs). \| `false` \|

in_opentelemetry: fix typo and sort configuration parameters #2298

Are you sure you want to change the base?

in_opentelemetry: fix typo and sort configuration parameters #2298

Uh oh!

Conversation

eschabell commented Dec 12, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

eschabell commented Dec 12, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

patrick-stephens Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

alexakreizinger Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

alexakreizinger Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

alexakreizinger Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

alexakreizinger left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

eschabell commented Dec 12, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 12, 2025 •

edited

Loading