Skip to content

Conversation

@eschabell
Copy link
Collaborator

@eschabell eschabell commented Dec 12, 2025

  • Change collector.thermal_zone.scrape_interval to collector.thermalzone.scrape_interval to match source code config_map in ne.c
  • Remove errant trailing quote from systemd_exclude_pattern default value

Fixes #2296.

Summary by CodeRabbit

  • Documentation

    • Updated node exporter metrics configuration documentation.
  • Chores

    • Renamed configuration key collector.thermal_zone.scrape_interval to collector.thermalzone.scrape_interval.
    • Updated systemd_exclude_pattern configuration pattern formatting.

✏️ Tip: You can customize this high-level summary in your review settings.

- Change collector.thermal_zone.scrape_interval to collector.thermalzone.scrape_interval
  to match source code config_map in ne.c
- Remove errant trailing quote from systemd_exclude_pattern default value

Fixes fluent#2296.

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell requested a review from esmerel December 12, 2025 15:33
@eschabell eschabell self-assigned this Dec 12, 2025
@eschabell eschabell requested review from a team as code owners December 12, 2025 15:33
@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 4.2.1 labels Dec 12, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 12, 2025

Walkthrough

This PR corrects documentation errors in the node-exporter-metrics input file: renames the collector.thermal_zone.scrape_interval configuration key to collector.thermalzone.scrape_interval and fixes the systemd_exclude_pattern documentation by removing extraneous quote and parenthesis characters.

Changes

Cohort / File(s) Summary
Documentation fixes
pipeline/inputs/node-exporter-metrics.md
Fixed configuration key naming inconsistency: collector.thermal_zone.scrape_intervalcollector.thermalzone.scrape_interval. Corrected systemd_exclude_pattern documentation by removing trailing quote and closing parenthesis.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • alexakreizinger

Poem

🐰 A doc's been tidied with care,
thermalzone typos laid bare,
Patterns now clean, no stray quote,
Our fluent streams sail in a boat! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main changes: fixing a config parameter name (collector.thermal_zone to collector.thermalzone) and a default value (removing errant trailing quote).
Linked Issues check ✅ Passed The pull request fully addresses the linked issue #2296 objectives: correcting the config parameter name to match source code and removing the trailing quote from the systemd_exclude_pattern default value.
Out of Scope Changes check ✅ Passed All changes in the pull request are directly related to the linked issue #2296; no out-of-scope modifications were detected beyond the intended documentation fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92fb0e1 and 912b918.

📒 Files selected for processing (1)
  • pipeline/inputs/node-exporter-metrics.md (2 hunks)
🔇 Additional comments (2)
pipeline/inputs/node-exporter-metrics.md (2)

55-55: Configuration parameter name corrected to match source code.

The change from collector.thermal_zone.scrape_interval to collector.thermalzone.scrape_interval aligns the documentation with the actual config key name in the source code. The description still correctly references thermal_zone metrics, which is the appropriate metric type name.


67-67: Fixed errant trailing quote in regex pattern default value.

The removal of the trailing quote from the systemd_exclude_pattern default value corrects a clear typographical error. The regex pattern now appears syntactically correct.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eschabell eschabell removed the request for review from esmerel December 12, 2025 15:34
@eschabell eschabell merged commit 6d31204 into fluent:master Dec 12, 2025
8 checks passed
@eschabell eschabell deleted the erics_in_node_exporter_metrics_fixes branch December 12, 2025 15:40
@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

input: node-exporter-metrics fixes and typos in doc

2 participants