-
Notifications
You must be signed in to change notification settings - Fork 545
Note that envvar cannot be used in include section #2289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughAdded documentation clarifications stating that include directives in Fluent Bit do not support environment variables and that included file paths must be specified as literal strings. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
administration/configuring-fluent-bit/yaml/includes-section.md (1)
29-30: Consider adding a reference link to guide users toward workarounds.The clarification accurately states that environment variables aren't supported in the includes section. However, per the PR objectives, a link to the referenced issue (fluent/fluent-bit#2020) should be included to help users discover workaround discussions.
Apply this diff to add context for users seeking alternatives:
-Environment variables are not supported in includes section. The file path must be specified as a literal string. +Environment variables are not supported in includes section. The file path must be specified as a literal string. For workaround discussions, see [this issue](https://github.com/fluent/fluent-bit/issues/2020).
88b73b5 to
8a75226
Compare
Signed-off-by: Jimin Ha <jimin9038@g.skku.edu>
|
@eschabell Hi, this is not updating to reflect code changes. This describes the current limitation of Fluent Bit's configuration syntax of YAML. |
|
Is this a limitation of just the YAML format? I thought I'd used env vars for includes in classic before. We should call out the delta if so and/or update the classic docs as well. |
|
@patrick-stephens Sorry for late reply. |
Signed-off-by: Jimin Ha <jimin9038@g.skku.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
administration/configuring-fluent-bit/classic-mode/configuration-file.md (1)
162-163: Adds appropriate clarification on environment variable limitation.This note correctly documents an existing limitation in Fluent Bit's include functionality, addressing the documentation gap mentioned in the PR. The placement at the end of the "Config include file" section is logical and the statement is clear.
Consider these minor optional improvements:
- Grammar: Change "in includes section" to "in the includes section" for consistency with the documentation style elsewhere in the file.
- Cross-reference (optional): If the related YAML docs change includes a reference to the GitHub issue (#2020) mentioned in the PR objectives as a workaround discussion, consider adding a similar reference here for consistency and to help users seeking workarounds.
-Environment variables aren't supported in includes section. The file path must be specified as a literal string. +Environment variables are not supported in the includes section. The file path must be specified as a literal string.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
administration/configuring-fluent-bit/classic-mode/configuration-file.md(1 hunks)administration/configuring-fluent-bit/yaml/includes-section.md(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- administration/configuring-fluent-bit/yaml/includes-section.md
This PR is a short addition noting that environment variables cannot be used in the include section.
Some users may attempt to use environment variables in the include section and eventually run into issues - often ending up at workaround discussions such as this one: fluent/fluent-bit#2020
It would be great to add a note clarifying that the include section does not parse environment variables, and, if possible, include a link to the above issue as a reference for the workaround.
Thank you!
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.