Skip to content

Allow overriding MSVC runtime library setting in CMake#340

Merged
tremblap merged 1 commit intoflucoma:mainfrom
emuell:feature/msvc-runtime-cache
Mar 24, 2026
Merged

Allow overriding MSVC runtime library setting in CMake#340
tremblap merged 1 commit intoflucoma:mainfrom
emuell:feature/msvc-runtime-cache

Conversation

@emuell
Copy link
Copy Markdown
Contributor

@emuell emuell commented Mar 18, 2026

I'm working on Rust bindings for FluCoMa, based on flucoma-core. See https://github.com/emuell/flucoma-rs

This still is a WIP, but works great so far, with one little caveat: Rust by default uses the Multi-threaded DLL runtime with msvc targets. This can be overridden, but is quite awkward and requires all users of the flucoma-rs crate to override the runtime as well which may cause various other problems.

flucoma-core right now does not allow overriding the CMAKE CMAKE_MSVC_RUNTIME_LIBRARY variables. This PR changes this. The default still is /MT, so this should not break anything else.

Update CMAKE_MSVC_RUNTIME_LIBRARY to use CACHE option.
@tremblap
Copy link
Copy Markdown
Member

@weefuzzy is currently working on the cmake stuff, so maybe this is timely to be added?

@emuell
Copy link
Copy Markdown
Contributor Author

emuell commented Mar 24, 2026

Any chance of getting that included? I can work around this by using a fork, but it would be great to let the Rust wrapper use the official sources.

@tremblap tremblap requested a review from weefuzzy March 24, 2026 14:39
Copy link
Copy Markdown
Member

@weefuzzy weefuzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok.

Note that it will be a temporary tweak, because I don't think we should be setting this variable in core in the first place (and if we do, probably in a preset rather than CMakeLists). But my CMake changes won't appear for a while.

@tremblap, I don't think this will have any side effects for us, but worth checking the next nightlies for Max (in particular) on Windows, just in case.

@tremblap
Copy link
Copy Markdown
Member

thanks @weefuzzy I'll take it for a ride on Windows compile and see. if it works locally, I'll merge.

@tremblap
Copy link
Copy Markdown
Member

arghhhh the weeds of cross-compiling. I hate windows.

@tremblap tremblap merged commit 532ea53 into flucoma:main Mar 24, 2026
3 checks passed
@emuell
Copy link
Copy Markdown
Contributor Author

emuell commented Mar 24, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants