Repository navigation
fix(style): grid counts keep subgrid and variable tracks; Subgrid switch - #85
Merged
flowtricks merged 1 commit intoNov 16, 2026
Merged
Conversation
The Columns and Rows counts showed a number for values they cannot count: `subgrid`, and a `repeat()` counted by a variable, such as Lumos's Grid (`repeat(var(--_column-count), …)`). Typing or stepping a count then replaced the value with plain tracks. Those counts now show "Subgrid" or "Custom" and can't be edited; the full value is their tooltip, and the grid settings edit it. The grid settings get a subgrid switch on each axis. Switching it on writes `subgrid` and remembers the value it replaced, so switching it off while the settings are open puts that value back; with nothing to put back, off removes the property. The new texts are translated in the five languages. "Subgrid" stays the same word in each, since it is the CSS feature's name, and "Custom" reuses the existing grid translation.
Contributor
Author
|
The macOS shard 4/4 never got a runner and was cancelled while still queued (no steps ran), so the macOS aggregate check failed. Could you re-run the failed jobs? Every other job passed, and the full gate passed locally (974/974). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Columns and Rows counts showed a number for values they cannot count:
subgrid, and arepeat()counted by a variable, such as Lumos's Grid (repeat(var(--_column-count), …)). Typing or stepping a count then replaced the value with plain tracks. Those counts now show "Subgrid" or "Custom" and can't be edited; the full value is their tooltip, and the grid settings edit it.The grid settings get a subgrid switch on each axis. Switching it on writes
subgridand remembers the value it replaced, so switching it off while the settings are open puts that value back; with nothing to put back, off removes the property.The new texts are translated in the five languages. "Subgrid" stays the same word in each, since it is the CSS feature's name, and "Custom" reuses the existing grid translation.
How it was tested
test/renderer/style/gridTracks.test.js: 104 checks, including the held counts, the switch on and off, and putting the replaced value back.grid-row: span 3withsubgridrows, then the same withgrid-column: span 3andsubgridcolumns. The switch, the counts and putting the value back all behave as described, on both axes.