Skip to content

fix(style): grid counts keep subgrid and variable tracks; Subgrid switch - #85

Merged
flowtricks merged 1 commit into
flowtricks:mainfrom
SylvainDruaux:fix/grid-subgrid-counters
Nov 16, 2026
Merged

flowtricks merged 1 commit into
flowtricks:mainfrom
SylvainDruaux:fix/grid-subgrid-counters

Conversation

@SylvainDruaux

Copy link
Copy Markdown
Contributor

The Columns and Rows counts showed a number for values they cannot count: subgrid, and a repeat() counted by a variable, such as Lumos's Grid (repeat(var(--_column-count), …)). Typing or stepping a count then replaced the value with plain tracks. Those counts now show "Subgrid" or "Custom" and can't be edited; the full value is their tooltip, and the grid settings edit it.

The grid settings get a subgrid switch on each axis. Switching it on writes subgrid and remembers the value it replaced, so switching it off while the settings are open puts that value back; with nothing to put back, off removes the property.

The new texts are translated in the five languages. "Subgrid" stays the same word in each, since it is the CSS feature's name, and "Custom" reuses the existing grid translation.

How it was tested

  • test/renderer/style/gridTracks.test.js: 104 checks, including the held counts, the switch on and off, and putting the replaced value back.
  • Full local gate: 974/974.
  • By hand in Desktop, on a Lumos project: three cards in a 3-column grid, each card grid-row: span 3 with subgrid rows, then the same with grid-column: span 3 and subgrid columns. The switch, the counts and putting the value back all behave as described, on both axes.

The Columns and Rows counts showed a number for values they cannot count: `subgrid`, and a `repeat()` counted by a variable, such as Lumos's Grid (`repeat(var(--_column-count), …)`). Typing or stepping a count then replaced the value with plain tracks. Those counts now show "Subgrid" or "Custom" and can't be edited; the full value is their tooltip, and the grid settings edit it.

The grid settings get a subgrid switch on each axis. Switching it on writes `subgrid` and remembers the value it replaced, so switching it off while the settings are open puts that value back; with nothing to put back, off removes the property.

The new texts are translated in the five languages. "Subgrid" stays the same word in each, since it is the CSS feature's name, and "Custom" reuses the existing grid translation.
@SylvainDruaux

Copy link
Copy Markdown
Contributor Author

The macOS shard 4/4 never got a runner and was cancelled while still queued (no steps ran), so the macOS aggregate check failed. Could you re-run the failed jobs? Every other job passed, and the full gate passed locally (974/974).

@flowtricks
flowtricks merged commit 6b81e32 into flowtricks:main Nov 16, 2026
20 of 22 checks passed
@SylvainDruaux
SylvainDruaux deleted the fix/grid-subgrid-counters branch November 17, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants