Repository navigation
Show explicit stylesheet locks when selector usage is uncertain - #84
Merged
flowtricks merged 1 commit intoNov 16, 2026
Merged
Conversation
A possible outside HTML source can leave every unmatched global selector uncertain, hiding an explicit stylesheet lock in the panel. Classify those locked selectors as kept so the panel reflects the user’s retention choice. Unlocking restores the underlying uncertainty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the Bunny video triggers “Can’t tell”
In an Astro Lumos starter with
patterns.cssandutilities.cssexplicitly locked, adding a Bunny HLS player caused the Style selectors panel to show Can’t tell for selectors in those files. Its diagnostic pointed to both the Bunny helper and the section wrapper.The helper in
src/lib/media/bunny.tsfetches an HLS playlist as text, sums the#EXTINFdurations, and writes the formatted time withtextContent. Separately,src/components/wrapper/Section.astrousesset:htmlto render its Astro slots. Stacki’s import analysis sees an external data source and an HTML insertion site in the same page’s dependency graph. It conservatively accounts for the possibility of class names arriving at runtime. In this example the playlist text never reaches the HTML insertion site.Change
Previously,
lockedVerdictmapped onlyunusedtokept. Anunknownresult therefore hid an explicit stylesheet or folder lock in the panel. This change maps both verdicts tokeptwhen the stylesheet is locked. Used and untracked selectors retain their existing classifications. Unlocking exposes the underlying uncertainty again. The outside-HTML analysis still applies to unlocked stylesheets.Verification
npm run check:changedpasses.Verification covered the analyser and source checks. The full Electron runtime suite and a rebuilt desktop UI were not exercised.