Skip to content

Allow explicit feature creation in strict mode - #1042

Open
oiahoon wants to merge 1 commit into
flippercloud:mainfrom
oiahoon:fix/strict-add
Open

Allow explicit feature creation in strict mode#1042
oiahoon wants to merge 1 commit into
flippercloud:mainfrom
oiahoon:fix/strict-add

Conversation

@oiahoon

@oiahoon oiahoon commented Aug 17, 2026

Copy link
Copy Markdown

Fixes #1026

Summary

  • let explicit Flipper.add calls use the strict adapter's existing scoped check bypass
  • keep strict checks active for implicit feature creation through operations such as enable
  • add regression coverage for both behaviors

Test plan

  • bundle exec rspec spec/flipper/dsl_spec.rb spec/flipper/adapters/strict_spec.rb
  • core RSpec suite excluding service/socket/terminal-dependent files (2,595 examples, 0 failures)
  • core Minitest suite excluding Redis-dependent files (242 runs, 4,636 assertions, 0 failures)
  • Rails generator and helper tests (14 runs, 111 assertions, 0 failures)
  • bundle exec rake build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strict mode warning when calling Flipper.add() on a new feature

1 participant