Skip to content

Add list-setter shadow blocks at top of Lists flyout #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tracygardner merged 1 commit into from
Feb 23, 2026
Merged

Add list-setter shadow blocks at top of Lists flyout #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 113 additions & 0 deletions main/blocklyinit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,119 @@ export function initializeWorkspace() {
return xmlList;
});

workspace.registerToolboxCategoryCallback("LIST", function (ws) {
const xmlList = [];
const variableMap = ws.getVariableMap();
const getNextListName = () => {
const vars = variableMap.getAllVariables();
let maxSuffix = 0;
vars.forEach((model) => {
const match = model.name.match(/^list(\d+)$/);
if (match) {
maxSuffix = Math.max(
maxSuffix,
parseInt(match[1], 10),
);
}
});
return `list${maxSuffix + 1}`;
};

const createSetListBlock = (valueBuilder) => {
const block = document.createElement("block");
block.setAttribute("type", "variables_set");

const field = document.createElement("field");
field.setAttribute("name", "VAR");
field.setAttribute("variabletype", "");
field.textContent = getNextListName();
block.appendChild(field);

const value = document.createElement("value");
value.setAttribute("name", "VALUE");
value.appendChild(valueBuilder());
block.appendChild(value);

return block;
};

const createListShadow = (shadowType, values) => {
const shadow = document.createElement("shadow");
shadow.setAttribute("type", "lists_create_with");
shadow.setAttribute("inline", "true");

const mutation = document.createElement("mutation");
mutation.setAttribute("items", "2");
shadow.appendChild(mutation);

values.forEach((value, index) => {
const valueNode = document.createElement("value");
valueNode.setAttribute("name", `ADD${index}`);
const childShadow = document.createElement("shadow");
childShadow.setAttribute("type", shadowType);
const field = document.createElement("field");
field.setAttribute(
"name",
shadowType === "math_number"
? "NUM"
: shadowType === "colour"
? "COLOR"
: "TEXT",
);
field.textContent = String(value);
childShadow.appendChild(field);
valueNode.appendChild(childShadow);
shadow.appendChild(valueNode);
});

return shadow;
};

xmlList.push(
createSetListBlock(() => {
const shadow = document.createElement("shadow");
shadow.setAttribute("type", "lists_create_empty");
return shadow;
}),
);
xmlList.push(
createSetListBlock(() =>
createListShadow("math_number", [1, 2]),
),
);
xmlList.push(
createSetListBlock(() => createListShadow("text", ["", ""])),
);
xmlList.push(
createSetListBlock(() =>
createListShadow("colour", ["#ff0000", "#0000ff"]),
),
);

[
"lists_create_empty",
"lists_create_with",
"lists_repeat",
"lists_length",
"lists_isEmpty",
"lists_indexOf",
"lists_getIndex",
"lists_setIndex",
"lists_getSublist",
"lists_split",
"lists_sort",
].forEach((type) => {
const block = document.createElement("block");
block.setAttribute("type", type);
if (type === "lists_create_with") {
block.setAttribute("inline", "true");
}
xmlList.push(block);
});

return xmlList;
});

// Add change listeners
workspace.addChangeListener(BlockDynamicConnection.finalizeConnections);
workspace.addChangeListener(handleBlockSelect);
Expand Down
3 changes: 2 additions & 1 deletion toolbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3273,6 +3273,7 @@ const toolboxLists = {
icon: "./images/lists.svg",
//colour: categoryColours["Lists"],
categorystyle: "variables_category",
custom: "LIST",
contents: [
{
kind: "block",
Expand Down Expand Up @@ -4896,4 +4897,4 @@ Blockly.registry.register(
Blockly.CollapsibleToolboxCategory.registrationName,
CustomCollapsibleToolboxCategory,
true,
);
);