Skip to content

fix(ui): clean up projects page #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielnaab wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): clean up projects page #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/entrypoints/app/routes/projects.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type { Context } from 'hono'
import { Breadcrumb } from '../../../design-system/components/flex-breadcrumb/index'
import { Layout } from '../../../design-system/components/flex-layout/index'
import type { ProjectService } from '../../../services/projects'
import { resolveUrl } from '../../../shared/base-path'
Expand All @@ -12,9 +11,15 @@ export function projectsDirectoryHandler(projectService: ProjectService) {
.filter((p) => p.status === 'ready')
return c.html(
<Layout user={user} title="Projects" currentSection="projects">
<Breadcrumb items={[{ label: 'Projects' }]} />
<div class="flex-form" data-size="large">
<h1>Projects</h1>
<div class="l-cluster justify-between" style="align-items: baseline;">
<h1>Projects</h1>
{user && (
<a href={resolveUrl('/new')} class="flex-button">
New Project
</a>
)}
</div>
{projects.length === 0 ? (
<p>No projects yet.</p>
) : (
Expand Down
15 changes: 12 additions & 3 deletions test/projects/directory-route.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,13 +180,22 @@ describe('GET /projects — projects directory route', () => {
expect(html).toContain('Projects | Forms Lab')
})

it('renders breadcrumb with "Projects" label', async () => {
it('shows New Project button for logged-in users', async () => {
const { service } = makeService()
const app = createTestApp(service)

const res = await app.request('/projects')
const html = await res.text()
expect(html).toContain('flex-breadcrumb')
expect(html).toContain('Projects')
expect(html).toContain('New Project')
expect(html).toContain('/new')
})

it('hides New Project button for anonymous users', async () => {
const { service } = makeService()
const app = createTestApp(service, null)

const res = await app.request('/projects')
const html = await res.text()
expect(html).not.toContain('New Project')
})
})
Loading