Skip to content

feat: stream-wide review with outdated comments - #66

Merged
flexdinesh merged 1 commit into
codex/sidebar-inprocess-refreshfrom
codex/stream-review
Oct 15, 2026
Merged

flexdinesh merged 1 commit into
codex/sidebar-inprocess-refreshfrom
codex/stream-review

Conversation

@flexdinesh

Copy link
Copy Markdown
Owner

Stacked on #65.

  • Review state (comments, reviewed marks) now per stream (owner/source/repo/checkout/branch/comparison), spanning snapshots — new snapshots no longer orphan reviews.
  • review.Locate: pure placement rule — anchored / moved / outdated / unchanged / other-scope / unknown. Re-anchors via unique block+captured-context match, block-only unique match also counts; ambiguous/no match → outdated. Shared Go/TS examples in test/contracts/comments.json.
  • Comments capture surrounding context on create; marks carry while file patch digest unchanged.
  • POST …/comments/{id}/carry ("Keep open"): outdated comment → file-level comment on current snapshot, keeps original code + carriedFrom, still labelled outdated.
  • DELETE …/comments?status=outdated; exports tag stale="true"; MCP/agent list returns placement applicability.
  • Stream ends when last snapshot pruned/deleted → review rows removed in same txn; stream heads kept.
  • UI: "N outdated" file header slot, Outdated section + filter in Comments panel, muted tree count, outdated-comments banner, placement notes ("Moved from line X").
  • Schema 10→11 reset (no migration). Docs updated (system, architecture, development, mcp, release, README, DESIGN).
  • Shared across local and remote; boundary test covers both compositions.

Validation: mise run check passes (Go tests incl. race on review pkgs, contracts 36/36, web unit 53, browser 78); dist drift clean.

Known limits: anchors captured from hunks only (full-contents fallback may resolve as unchanged); content-only comparison; one mark per stream+scope+file; export <review> still grouped by origin revision.

Comments and marks span stream snapshots; comments re-anchor by content or show as outdated; Keep open; stale export tags; schema 11.
@flexdinesh
flexdinesh marked this pull request as ready for review October 15, 2026 06:33
@flexdinesh
flexdinesh merged commit 337095e into codex/sidebar-inprocess-refresh Oct 15, 2026
1 check passed
flexdinesh added a commit that referenced this pull request Oct 15, 2026
* feat: scope local mode to its checkout, add local refresh, nav project search

- local process lists/reads only its checkout or piped capture
- POST /api/v2/collections recollects checkout on explicit refresh (Alt+R)
- header shows static repo/branch/worktree; picker via Cmd/Ctrl+K or nav
- projects nav gets inline project search
- persist collapsed diff files and tree folders in sessionStorage

* feat: stream-wide review with outdated comments (#66)

Comments and marks span stream snapshots; comments re-anchor by content or show as outdated; Keep open; stale export tags; schema 11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant