-
Notifications
You must be signed in to change notification settings - Fork 66
chore: core web packages updates (FXC-4147) #2992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
542d24f to
5a0076a
Compare
5a0076a to
14de785
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changesNo lines with coverage information in this diff. |
momchil-flex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally fine, at some point we should unpin h5py though.
14de785 to
1fb3bb8
Compare
|
I think after the lambda refactor |
1fb3bb8 to
89a3d4f
Compare
Required for webapi, as we were using jedi indirectly in our web client. It'd be ideal if things were more decoupled but it's a bigger refactor.
Tested by
Again
Greptile Overview
Greptile Summary
This PR downgrades
h5pyfrom version 3.15.1 to 3.14.0 for backend compatibility and addsjedias a core dependency.Key Changes:
h5pyconstraint from^3.0.0to>=3.0.0,<3.15inpyproject.toml, with lock file updated to 3.14.0jedi^0.19 as a core dependency (previously optional dev/docs dependency)poetry.lockfor better compatibility (e.g.,python_version < "3.11"changed topython_version == "3.10")Concerns:
h5pydowngradejedito core increases installation footprint for all usersConfidence Score: 4/5
jedia core dependency inpyproject.tomlImportant Files Changed
File Analysis
h5pyfrom ^3.0.0 to >=3.0.0,<3.15 and addedjedi^0.19 as a core dependencySequence Diagram
sequenceDiagram participant Dev as Developer participant Poetry as Poetry Tool participant PyPI as PyPI Registry participant Backend as Backend System Dev->>Poetry: Update pyproject.toml<br/>(h5py: ^3.0.0 → >=3.0.0,<3.15) Dev->>Poetry: Add jedi ^0.19 to core deps Dev->>Poetry: poetry lock Poetry->>PyPI: Resolve h5py versions PyPI-->>Poetry: Return 3.14.0 (latest < 3.15) Poetry->>PyPI: Resolve jedi versions PyPI-->>Poetry: Return jedi 0.19.2 Poetry->>Poetry: Update poetry.lock Note over Poetry: Downgrade h5py 3.15.1 → 3.14.0<br/>Move jedi from optional to core Poetry-->>Dev: Lock file updated Dev->>Backend: Deploy with h5py 3.14.0 Note over Backend: Backend compatibility<br/>maintained with h5py < 3.15Context used:
dashboard- Require a changelog entry for any PR that is not purely an internal refactor. (source)