Skip to content

Add allenhouchins as maintainer for pkg/patch_policy - #52640

Open
allenhouchins wants to merge 3 commits into
mainfrom
allenhouchins/patch-policy-auto-approve-57fbdc
Open

Add allenhouchins as maintainer for pkg/patch_policy#52640
allenhouchins wants to merge 3 commits into
mainfrom
allenhouchins/patch-policy-auto-approve-57fbdc

Conversation

@allenhouchins

@allenhouchins allenhouchins commented Sep 6, 2026

Copy link
Copy Markdown
Member

Requesting this access since the vast majority of Windows Fleet-maintained apps require custom patch policies.

Related issue: N/A

Summary

Adds pkg/patch_policy to githubRepoMaintainersByPath in website/config/custom.js with allenhouchins as maintainer.

pkg/patch_policy holds the patch policy query generation shared by the Fleet-maintained apps (FMA) tooling and the Fleet server. It is maintained alongside ee/maintained-apps, which already lists the same maintainer, so PRs that only touch this package should auto-approve and be unfreezable the same way FMA changes are.

Reviewer notes

  • Only the maintainers map is changed. The DRI map (githubRepoDRIByPath) is left alone since it only controls review requests, not auto-approval.
  • Nothing in CODEOWNERS currently covers pkg/, so this adds no conflicting reviewer requirement.
  • Config-only change to the website's repo-automation settings. No runtime code, tests, migrations, or user-visible behavior changes.
  • Verified the file still loads with node -e "require('./website/config/custom.js')".

Checklist for submitter

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.

Testing

  • QA'd all new/changed functionality manually

Summary by CodeRabbit

  • Chores
    • Updated repository path-based approval settings for changes under pkg/patch_policy.

allenhouchins and others added 2 commits September 5, 2026 23:07
The patch policy query generation package is FMA tooling, so PRs touching
only that path should auto-approve the same way ee/maintained-apps does.
Removed 'and the Fleet server' from the patch policy comment.
@allenhouchins allenhouchins changed the title Add allenhouchins as DRI for pkg/patch_policy Add allenhouchins as a DRI for pkg/patch_policy Sep 6, 2026
@allenhouchins allenhouchins changed the title Add allenhouchins as a DRI for pkg/patch_policy Add allenhouchins as maintainer for pkg/patch_policy Sep 6, 2026
Auto-approval is driven by githubRepoMaintainersByPath; the DRI map only
controls review requests.
@allenhouchins
allenhouchins marked this pull request as ready for review September 6, 2026 05:15
Copilot AI lite review requested due to automatic review settings September 6, 2026 05:15
@fleet-release
fleet-release requested a review from eashaw September 6, 2026 05:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a minimal, correctly formatted maintainers-by-path mapping addition that matches existing automation behavior (string value is supported and ancestor-path matching will apply to files under pkg/patch_policy/).

Pull request overview

Adds a maintainer mapping so pull requests touching pkg/patch_policy can be auto-preapproved/unfreezable under the same automation used for Fleet-maintained apps (FMA) paths.

Changes:

  • Add pkg/patch_policy to githubRepoMaintainersByPath with allenhouchins as maintainer.
File summaries
File Description
website/config/custom.js Adds pkg/patch_policy maintainer entry to the repo automation maintainers-by-path map.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 6ef93e23-98f1-4278-9483-2c92aabf6558

📥 Commits

Reviewing files that changed from the base of the PR and between 658ea38 and 0bf18c9.

📒 Files selected for processing (1)
  • website/config/custom.js

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


Walkthrough

The githubRepoMaintainersByPath mapping now assigns allenhouchins to the pkg/patch_policy path for automatic approval.

Merge Risk: ⚪ Minimal · up to 0bf18

Changes under pkg/patch_policy can now be automatically approved by the assigned maintainer. The mapping resolves as intended, with no current merge-readiness risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the maintainer assignment for the pkg/patch_policy path, which is the main change.
Description check ✅ Passed The description explains the change, its purpose, scope, reviewer considerations, related issue status, and validation performed. It also marks the applicable checklist items. Irrelevant checklist ite…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allenhouchins/patch-policy-auto-approve-57fbdc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants