Add allenhouchins as maintainer for pkg/patch_policy - #52640
Add allenhouchins as maintainer for pkg/patch_policy#52640allenhouchins wants to merge 3 commits into
Conversation
The patch policy query generation package is FMA tooling, so PRs touching only that path should auto-approve the same way ee/maintained-apps does.
Removed 'and the Fleet server' from the patch policy comment.
Auto-approval is driven by githubRepoMaintainersByPath; the DRI map only controls review requests.
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, correctly formatted maintainers-by-path mapping addition that matches existing automation behavior (string value is supported and ancestor-path matching will apply to files under pkg/patch_policy/).
Pull request overview
Adds a maintainer mapping so pull requests touching pkg/patch_policy can be auto-preapproved/unfreezable under the same automation used for Fleet-maintained apps (FMA) paths.
Changes:
- Add
pkg/patch_policytogithubRepoMaintainersByPathwithallenhouchinsas maintainer.
File summaries
| File | Description |
|---|---|
| website/config/custom.js | Adds pkg/patch_policy maintainer entry to the repo automation maintainers-by-path map. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. WalkthroughThe Merge Risk: ⚪ Minimal · up to Changes under pkg/patch_policy can now be automatically approved by the assigned maintainer. The mapping resolves as intended, with no current merge-readiness risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Requesting this access since the vast majority of Windows Fleet-maintained apps require custom patch policies.
Related issue: N/A
Summary
Adds
pkg/patch_policytogithubRepoMaintainersByPathinwebsite/config/custom.jswithallenhouchinsas maintainer.pkg/patch_policyholds the patch policy query generation shared by the Fleet-maintained apps (FMA) tooling and the Fleet server. It is maintained alongsideee/maintained-apps, which already lists the same maintainer, so PRs that only touch this package should auto-approve and be unfreezable the same way FMA changes are.Reviewer notes
githubRepoDRIByPath) is left alone since it only controls review requests, not auto-approval.CODEOWNERScurrently coverspkg/, so this adds no conflicting reviewer requirement.node -e "require('./website/config/custom.js')".Checklist for submitter
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.Testing
Summary by CodeRabbit
pkg/patch_policy.