Skip to content

Allow concurrent make lint-go executions#44724

Merged
lucasmrod merged 1 commit intomainfrom
allow-concurrent-make-lint-go
May 5, 2026
Merged

Allow concurrent make lint-go executions#44724
lucasmrod merged 1 commit intomainfrom
allow-concurrent-make-lint-go

Conversation

@lucasmrod
Copy link
Copy Markdown
Member

@lucasmrod lucasmrod commented May 5, 2026

Usually I type make lint-go > enter, and then I go to do other stuff and when I come back to the terminal I see this error (possibly because VS Code is also running it?):

$ make lint-go
golangci-lint run --timeout 15m
Error: parallel golangci-lint is running
The command is terminated due to an error: parallel golangci-lint is running

Flag --allow-serial-runners is useful for this scenario:

--allow-serial-runners  Allow multiple golangci-lint instances running, but serialize them around a lock.

Summary by CodeRabbit

  • Chores
    • Updated internal build configuration for linting tools to enhance performance during development and testing cycles.

Copilot AI review requested due to automatic review settings May 5, 2026 11:01
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Go lint Make targets to allow multiple golangci-lint runs to coexist by serializing execution via golangci-lint’s runner lock, preventing the “parallel golangci-lint is running” failure during concurrent invocations.

Changes:

  • Add --allow-serial-runners to make lint-go (full lint).
  • Add --allow-serial-runners to make lint-go-incremental (custom-gcl incremental lint).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

Walkthrough

The Makefile's linting targets are updated to add the --allow-serial-runners flag. The lint-go target now includes this flag in its golangci-lint run invocation while preserving the existing 15-minute timeout. The lint-go-incremental target is similarly updated to include the --allow-serial-runners flag in its ./custom-gcl run invocation, while maintaining all existing configuration parameters including the incremental config file, merge-base reference, timeout, and target scope.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description explains the problem and the solution, but does not follow the required repository template with sections like Related issue, Checklist items, Testing, Database migrations, etc. Update the PR description to include the standard template sections: Related issue, Checklist for submitter (with relevant items), Testing section, and other required sections applicable to this change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Allow concurrent make lint-go executions' clearly and concisely summarizes the main change: adding support for concurrent golangci-lint executions via the --allow-serial-runners flag.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allow-concurrent-make-lint-go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lucasmrod lucasmrod merged commit c2ba0ca into main May 5, 2026
13 checks passed
@lucasmrod lucasmrod deleted the allow-concurrent-make-lint-go branch May 5, 2026 12:10
Copy link
Copy Markdown
Collaborator

@sharon-fdm sharon-fdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve as well per this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants