Allow concurrent make lint-go executions#44724
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Pull request overview
This PR updates the Go lint Make targets to allow multiple golangci-lint runs to coexist by serializing execution via golangci-lint’s runner lock, preventing the “parallel golangci-lint is running” failure during concurrent invocations.
Changes:
- Add
--allow-serial-runnerstomake lint-go(full lint). - Add
--allow-serial-runnerstomake lint-go-incremental(custom-gcl incremental lint).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
WalkthroughThe Makefile's linting targets are updated to add the 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sharon-fdm
left a comment
There was a problem hiding this comment.
Approve as well per this
Usually I type
make lint-go> enter, and then I go to do other stuff and when I come back to the terminal I see this error (possibly because VS Code is also running it?):Flag
--allow-serial-runnersis useful for this scenario:Summary by CodeRabbit