disable data collection docs#44703
Open
sgress454 wants to merge 3 commits intodocs-v4.85.0from
Open
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
33 tasks
rachaelshaw
reviewed
May 4, 2026
fleet-release
approved these changes
May 4, 2026
rachaelshaw
reviewed
May 4, 2026
Comment on lines
+958
to
+966
| #### Example (global) | ||
|
|
||
| ```json | ||
| { | ||
| "dataset": "vulnerabilities", | ||
| "fleet_id": null, | ||
| "fleet_name": null | ||
| } | ||
| ``` |
Member
There was a problem hiding this comment.
I'm not opposed to keeping it, but we don't necessarily need the global/team-scoped example; we could just show the team example since we already specify certain fields are null if applied globally.
rachaelshaw
reviewed
May 4, 2026
Comment on lines
+987
to
+995
| #### Example (global) | ||
|
|
||
| ```json | ||
| { | ||
| "dataset": "uptime", | ||
| "fleet_id": null, | ||
| "fleet_name": null | ||
| } | ||
| ``` |
rachaelshaw
requested changes
May 4, 2026
Comment on lines
+2672
to
+2673
| | uptime | boolean | Whether to collect host activity samples that drive the Hosts Active dashboard chart. (Default: `true`) | | ||
| | vulnerabilities | boolean | Whether to collect per-host software vulnerability data that drive the Vulnerability Exposure dashboard chart. (Default: `true`) | |
Member
There was a problem hiding this comment.
I think we should leave out mention of the UI elements, since the audience for this is an API user.
Suggested change
| | uptime | boolean | Whether to collect host activity samples that drive the Hosts Active dashboard chart. (Default: `true`) | | |
| | vulnerabilities | boolean | Whether to collect per-host software vulnerability data that drive the Vulnerability Exposure dashboard chart. (Default: `true`) | | |
| | uptime | boolean | Whether to collect host activity samples. (Default: `true`) | | |
| | vulnerabilities | boolean | Whether to collect per-host software vulnerability data. (Default: `true`) | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: For #44077
Docs for the new
historical_dataconfig keys.