[WIP] Fix denial of service vulnerability in jsonparser#44702
Open
[WIP] Fix denial of service vulnerability in jsonparser#44702
Conversation
fleet-release
previously approved these changes
May 4, 2026
Agent-Logs-Url: https://github.com/fleetdm/fleet/sessions/db21cf24-e5b7-44ee-aa75-242fd9dd430b Co-authored-by: lukeheath <2495927+lukeheath@users.noreply.github.com>
lukeheath
approved these changes
May 6, 2026
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
lukeheath
approved these changes
May 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the tools/fleet-mcp module dependencies to address the Trivy-reported DoS vulnerability (CVE-2026-32285) in github.com/buger/jsonparser by moving off the vulnerable pseudo-version and pinning the fixed release.
Changes:
- Bump
github.com/buger/jsonparsertov1.1.2(fixed version for CVE-2026-32285). - Promote
golang.org/x/time v0.15.0from indirect to a direct dependency (it’s imported bytools/fleet-mcp/rate_limit.go).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/fleet-mcp/go.mod | Updates dependency requirements, pinning jsonparser to v1.1.2 and making x/time a direct require. |
| tools/fleet-mcp/go.sum | Updates module checksums to match the jsonparser v1.1.2 version change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.