Adding changes for Fleet v4.84.1#44525
Open
georgekarrv wants to merge 1 commit intomainfrom
Open
Conversation
georgekarrv
requested review from
a team,
BCTBB,
ddribeiro,
ksatter and
rfairburn
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (6)
WalkthroughThis PR increments Fleet-related versions from v4.84.0 to v4.84.1 across deployment and tooling references: Helm chart metadata ( Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Fleet release artifacts and deployment defaults to align with the Fleet v4.84.1 release, including Helm chart metadata and dogfood Terraform image tags.
Changes:
- Bumped Fleet version references from v4.84.0 → v4.84.1 across tooling, Helm, and dogfood Terraform.
- Incremented Helm chart version v6.9.1 → v6.9.2 and updated
appVersionto v4.84.1. - Added a new Fleet 4.84.1 section to
CHANGELOG.md.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/github-manage/cmd/gm/releases.go | Updates the example milestone for the gm releases forecast command to 4.84.1. |
| tools/fleetctl-npm/package.json | Bumps fleetctl npm installer package version to v4.84.1. |
| infrastructure/dogfood/terraform/gcp/variables.tf | Updates dogfood GCP default Fleet image tag to v4.84.1. |
| infrastructure/dogfood/terraform/aws/variables.tf | Updates dogfood AWS default Fleet image tag to v4.84.1. |
| charts/fleet/values.yaml | Updates default Helm image tag to v4.84.1. |
| charts/fleet/Chart.yaml | Bumps chart version and updates appVersion to v4.84.1. |
| CHANGELOG.md | Adds 4.84.1 changelog entry and adjusts one existing bullet formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - Fixed a bug where host environment variables in script-only packages would cause gitops to fail | ||
| - Updated go to 1.26.2 | ||
| - Fixed SCEP renewals not retrying after initial failure | ||
| - Extend SCEP enrollment/renewal challenge credential TTL |
| - Updated go to 1.26.2 | ||
| - Fixed SCEP renewals not retrying after initial failure | ||
| - Extend SCEP enrollment/renewal challenge credential TTL | ||
| - Fixed an issue where trying to wipe a device after its certificate was renewed could fail due to a missing bootstrap token. _Note: The device might still have wiped_ |
| - Fixed disk encryption key modal to not show stale key when switching between hosts. | ||
| - Fixed SCIM user not associating with host when IdP username was set before the SCIM user was created. | ||
| - Fixed Google Drive version not matching upstream. | ||
| - Fixed Google Drive version not matching upstream. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44525 +/- ##
==========================================
- Coverage 66.78% 66.76% -0.03%
==========================================
Files 2637 2637
Lines 212092 212186 +94
Branches 9518 9518
==========================================
+ Hits 141653 141665 +12
- Misses 57576 57676 +100
+ Partials 12863 12845 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
georgekarrv
force-pushed
the
update-changelog-prepare-4.84.1-main
branch
from
728795f to
4faaca8
Compare
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit