Skip to content

package.accept_keywords: unmask incus-7.5.1 - #4362

Merged
t-lo merged 2 commits into
mainfrom
t-lo/incus-7.5.1
Nov 6, 2026
Merged

package.accept_keywords: unmask incus-7.5.1#4362
t-lo merged 2 commits into
mainfrom
t-lo/incus-7.5.1

Conversation

@t-lo

@t-lo t-lo commented Nov 6, 2026

Copy link
Copy Markdown
Member

This change unmasks incus-7.5.1 for Flatcar. 7.0 is stable in Gentoo, 7.4 was stable in portage-stable before the Gentoo move. Gentoo currently does not have a stable version available for ARM64 at all.

To mitigate, we unmask 7.5.1 for AMD64 and ARM64 for Flatcar.

Ran a build for amd64 and arm64 locally (no tests).

@t-lo
t-lo requested a review from a team as a code owner November 6, 2026 09:18
Copilot AI balanced review requested due to automatic review settings November 6, 2026 09:18
Copilot AI reviewed Nov 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the Incus 7.5.1 keyword acceptance change.

No open issues 🎉

What changed in this PR

Updates Flatcar’s keyword acceptance to allow Incus 7.5.1 on AMD64 and ARM64, addressing the lack of a stable ARM64 version in Gentoo.

Changes:

  • Replaces the Incus 7.4-r1 entry with an exact 7.5.1 entry.
  • Updates the accompanying comment to describe its experimental status in Gentoo.
File Description
sdk_container/​src/​third_party/​coreos-overlay/​profiles/​coreos/​base/​package.accept_keywords Accepts Incus 7.5.1 in the shared Flatcar profile.

Review effort: Balanced

tormath1
tormath1 reviewed Nov 6, 2026
View reviewed changes

@tormath1 tormath1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but we might add some CVEs entries to the security changelog, at least: CVE-2026-85185 and CVE-2026-85185

@t-lo

t-lo commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

LGTM - but we might add some CVEs entries to the security changelog, at least: CVE-2026-85185 and CVE-2026-85185

That's the same CVE, and it's LXD though?

@tormath1

tormath1 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

LGTM - but we might add some CVEs entries to the security changelog, at least: CVE-2026-85185 and CVE-2026-85185

That's the same CVE, and it's LXD though?

Sorry, I meant:

And yes it's for LXD but they still share code (Incus is a community fork of LXD).

@t-lo
package.accept_keywords: unmask incus-7.5.1
44a706f 
This change unmasks incus-7.5.1 for Flatcar. 7.0 is stable in Gentoo,
7.4 was stable in portage-stable before the Gentoo move. Gentoo
currently does not have a stable version available for ARM64 at all.

To mitigate, we unmask 7.5.1 for AMD64 and ARM64 for Flatcar.

Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
@t-lo
t-lo force-pushed the t-lo/incus-7.5.1 branch from 4a259bd to 44a706f Compare November 6, 2026 10:37
Copilot AI balanced review requested due to automatic review settings November 6, 2026 10:37
@t-lo

t-lo commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

LGTM - but we might add some CVEs entries to the security changelog
That's the same CVE, and it's LXD though?
Sorry, I meant:

Added, thank you! Long term, we really want these to be added automatically. All we're doing here is rebuilding Gentoo ebuilds; this information must be available somewhere in Gentoo, or via generic CVE information?

@t-lo
t-lo requested review from a team and tormath1 November 6, 2026 10:38
Copilot AI reviewed Nov 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the Incus 7.5.1 keyword override and changelog updates.

No open issues 🎉

Review effort: Balanced

krnowak
krnowak requested changes Nov 6, 2026
View reviewed changes
Comment thread changelog/updates/2026-11-06-incus-7.5.1.md Resolved
Comment thread changelog/security/2026-11-06-incus-7.5.1.md Resolved
Copilot AI balanced review requested due to automatic review settings November 6, 2026 15:09
Copilot AI reviewed Nov 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the Incus 7.5.1 update.

No open issues 🎉

Review effort: Balanced

@t-lo @krnowak
Update changelog/updates|security/2026-11-06-incus-7.5.1.md
fb30b1c 
Co-authored-by: Krzesimir Nowak <knowak@microsoft.com>
Signed-off-by: Thilo Fromm <thilo.alexander@gmail.com>
@t-lo
t-lo force-pushed the t-lo/incus-7.5.1 branch from 341d126 to fb30b1c Compare November 6, 2026 15:13
Copilot AI balanced review requested due to automatic review settings November 6, 2026 15:13
@t-lo
t-lo requested a review from krnowak November 6, 2026 15:13
Copilot AI reviewed Nov 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the Incus 7.5.1 update and its accompanying release and security changelog entries.

No open issues 🎉

Review effort: Balanced

@t-lo
t-lo removed the request for review from tormath1 November 6, 2026 15:44
@t-lo
t-lo merged commit e853743 into main Nov 6, 2026
1 of 3 checks passed
@t-lo
t-lo deleted the t-lo/incus-7.5.1 branch November 6, 2026 15:44
@dongsupark dongsupark mentioned this pull request Nov 10, 2026
Closed

This branch is waiting to be deployed

1 waiting deployment
development — fb30b1cb Waiting Nov 6, 2026 by t-lo via Wait for approval #6093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tormath1 tormath1 tormath1 left review comments
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@krnowak krnowak krnowak approved these changes
@dongsupark dongsupark dongsupark approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@t-lo @tormath1 @krnowak @dongsupark