ci-automation: Drop unused Azure credential references#4137
Open
chewi wants to merge 1 commit into
Open
Conversation
These haven't been used since we switched to managed identities in bacf710. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
There was a problem hiding this comment.
Pull request overview
Removes legacy Azure secret-based authentication wiring from CI automation scripts, aligning the release and garbage-collection workflows with the post–managed-identity setup so Azure credentials can be dropped from Jenkins.
Changes:
- Removed AZURE_PROFILE / AZURE_AUTH_CREDENTIALS secret-to-file handling from the release workflow.
- Stopped forwarding AZURE_* credential env vars into the mantle container for cloud garbage collection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ci-automation/release.sh | Drops Azure secret env var documentation/references and removes writing Azure credential secrets to temp files before running plume. |
| ci-automation/garbage_collect.sh | Removes forwarding of AZURE_* credential env vars into the mantle container invocation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These haven't been used since we switched to managed identities in bacf710. I'm doing this so that I can drop the credentials from Jenkins. I can't really test it, but it seems trivial enough.