wip: misc updates and improvements#20
Draft
0x416e746f6e wants to merge 7 commits intopeg/add-sync-verifier-fnfrom
Draft
wip: misc updates and improvements#200x416e746f6e wants to merge 7 commits intopeg/add-sync-verifier-fnfrom
0x416e746f6e wants to merge 7 commits intopeg/add-sync-verifier-fnfrom
Conversation
Merged
ameba23
approved these changes
Apr 14, 2026
Collaborator
ameba23
left a comment
ameba23
left a comment
There was a problem hiding this comment.
🥇 Great to have these fixes.
Re: passing in keypair - i would lean towards having its as an Option and generating if not given. But don't feel too strongly.
Re: blocking API for attestation generation - i agree this makes sense as things are right now. But as mentioned here i would consider actually switching to async quote generation via configfs-tsm. Happy to merge this as-is and have that discussion later.
0x416e746f6e
force-pushed
the
anton/misc-updates-and-improvements
branch
2 times, most recently
from
56281b9 to
530838f
Compare
0x416e746f6e
force-pushed
the
anton/misc-updates-and-improvements
branch
from
530838f to
56281b9
Compare
(if in the future we add a new attestation type, the catch-all case will backfire)
0x416e746f6e
force-pushed
the
anton/misc-updates-and-improvements
branch
2 times, most recently
from
12ad663 to
8799225
Compare
Member
Author
implemented builder patterns for cert resolver and verifier. using predefined key-pair is now optional (as well as bunch of other things) |
0x416e746f6e
force-pushed
the
anton/misc-updates-and-improvements
branch
from
8799225 to
09d2638
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just an (ephemeral) PR with cherry-pickable commits