Conversation
2 tasks
Collaborator
Author
|
Pairs with BuilderNet/website#78 |
* main: Fix feature flag name to match convention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two CLI-facing improvements in order to behave more similar to
cvm-reverse-proxy'sattested-get:--allowed-remote-attestation-type tdxnow accepts any TDX platform attestation (dcap-tdx, qemu-tdx, gcp-tdx, azure-tdx).get-tls-certcan optionally write attestation measurements to a file via--out-measurements.It also extends certificate retrieval internals to return both certificate chain and optional measurements.
Key changes
MeasurementPolicy::tdx()convenience constructor.allowed_remote_attestation_type=tdxto that policy.get_tls_certAPI to return (cert_chain, measurements).--out-measurements <path>on get-tls-cert and persisted returned measurements.Known caveat
--out-measurements currently writes header-format JSON (from to_header_format()), which is different from --measurements-file policy schema.