Skip to content

Add json measurement output option and generic TDX attestation type to make CLI similar to cvm-reverse-proxy#142

Merged
ameba23 merged 3 commits intomainfrom
peg/fixes-for-get-tls-cert
Feb 26, 2026
Merged

Add json measurement output option and generic TDX attestation type to make CLI similar to cvm-reverse-proxy#142
ameba23 merged 3 commits intomainfrom
peg/fixes-for-get-tls-cert

Conversation

@ameba23
Copy link
Collaborator

@ameba23 ameba23 commented Feb 26, 2026

This PR adds two CLI-facing improvements in order to behave more similar to cvm-reverse-proxy's attested-get:

  1. --allowed-remote-attestation-type tdx now accepts any TDX platform attestation (dcap-tdx, qemu-tdx, gcp-tdx, azure-tdx).
  2. get-tls-cert can optionally write attestation measurements to a file via --out-measurements.

It also extends certificate retrieval internals to return both certificate chain and optional measurements.

Key changes

  1. Added MeasurementPolicy::tdx() convenience constructor.
  2. Updated CLI parsing to map allowed_remote_attestation_type=tdx to that policy.
  3. Extended get_tls_cert API to return (cert_chain, measurements).
  4. Added --out-measurements <path> on get-tls-cert and persisted returned measurements.

Known caveat

--out-measurements currently writes header-format JSON (from to_header_format()), which is different from --measurements-file policy schema.

@ameba23
Copy link
Collaborator Author

ameba23 commented Feb 26, 2026

Pairs with BuilderNet/website#78

@ameba23 ameba23 merged commit 838ad3d into main Feb 26, 2026
2 checks passed
@ameba23 ameba23 deleted the peg/fixes-for-get-tls-cert branch February 26, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant