[addon-operator] create module hook queues regardless of DoModuleStartup - #826
Merged
ldmonster merged 2 commits intoAug 21, 2026
Merged
Conversation
Signed-off-by: Artem Kuleshov <artem.kuleshov@flant.com>
Signed-off-by: Artem Kuleshov <artem.kuleshov@flant.com>
ldmonster
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Backport of #825 to
release-1.21, with thepkg/task/tasks/module-run/task.gopart of #797 that never reached this branch: theStartupphase no longer branches onhm.DoModuleStartup,QueueSynchronizationTasksre-ensures the queues, and a Synchronization task that cannot be queued fails the phase instead of being dropped.What this PR does / why we need it
modules.Startupis set only in theBasicModuleconstructor and inResetState, so a module in that phase has not completed its startup.DoModuleStartupduplicates that state and every ModuleRun producer computes it independently: converge sets it only for modules inModulesToEnable(converge-modules/task.go:155),functional.Scheduler.Addreplaces a stored request wholesale, andPushRunModuleTasknever sets it.A module that took such a task created no hook queues and ran no
onStartuphooks, and got neither back becausemodules.Startupis not re-entered. Its Synchronization tasks were dropped, the emptySynchronizationStatereportedIsCompleted() == true, and the chart was applied without the values those hooks were to fill.