Conversation
8051f99 to
2ddb5df
Compare
2ddb5df to
7231ce3
Compare
7de41f7 to
9cbabd5
Compare
fad4f61 to
3d31763
Compare
3d31763 to
9442604
Compare
9442604 to
bb53ffe
Compare
bb53ffe to
1903e6b
Compare
1903e6b to
878bfba
Compare
878bfba to
da72b97
Compare
da72b97 to
ce7aa20
Compare
3a8cf54 to
17da76d
Compare
bcac765 to
bd1da8e
Compare
bd1da8e to
15e5f4b
Compare
15e5f4b to
f73aa79
Compare
f73aa79 to
d8a2231
Compare
d8a2231 to
88b001a
Compare
88b001a to
04bdc37
Compare
04bdc37 to
d8e2182
Compare
d8e2182 to
e3c112e
Compare
1f78b21 to
8199d00
Compare
8199d00 to
ec8381f
Compare
ec8381f to
c396aad
Compare
c396aad to
cf89cef
Compare
WalkthroughThe pull request updates the go.mod file with newer versions across a wide range of module dependencies, including Kubernetes, gRPC, OpenTelemetry, Prometheus, and other ecosystem packages, with multiple API/ABI-impacting version bumps. Changes
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 12-14: The go.mod entry for sigs.k8s.io/controller-runtime
(currently v0.22.3) is incompatible with k8s.io/apimachinery and
k8s.io/client-go v0.35.2; update the controller-runtime version to v0.23.0 or
later in go.mod (sigs.k8s.io/controller-runtime v0.23.x) to match Kubernetes
v0.35.x, then run go mod tidy and run your unit/integration tests to ensure no
API breaks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 593b00d3-2dfa-4f61-abcc-000a8d714359
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| k8s.io/apimachinery v0.35.2 | ||
| k8s.io/client-go v0.35.2 | ||
| sigs.k8s.io/controller-runtime v0.22.3 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Is controller-runtime v0.22.3 compatible with k8s.io/client-go v0.35.2 and k8s.io/apimachinery v0.35.2?
💡 Result:
No, controller-runtime v0.22.3 is not compatible with k8s.io/client-go v0.35.2 and k8s.io/apimachinery v0.35.2. controller-runtime v0.22.x is tested and compatible only with k8s.io/client-go v0.34.x and k8s.io/apimachinery v0.34.x, as stated in the official compatibility matrix in the project's README and VERSIONING.md. Compatibility with other versions is unsupported and not tested. v0.35.x corresponds to Kubernetes 1.35, while v0.34.x aligns with Kubernetes 1.34. Use controller-runtime v0.23.x or later for v0.35.x support.
Citations:
- 1: https://github.com/kubernetes-sigs/controller-runtime
- 2: https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.22.4
- 3: https://godoc.org/sigs.k8s.io/controller-runtime?tab=versions
- 4: https://github.com/kubernetes-sigs/controller-runtime/releases
- 5: https://pkg.go.dev/k8s.io/client-go@v0.35.2
- 6: https://pkg.go.dev/k8s.io/apimachinery@v0.35.0
🏁 Script executed:
#!/bin/bash
# Description: Check controller-runtime's go.mod to see what k8s versions it requires
echo "Fetching controller-runtime v0.22.3 dependencies..."
curl -s "https://raw.githubusercontent.com/kubernetes-sigs/controller-runtime/v0.22.3/go.mod" | \
grep -E "k8s.io/(client-go|apimachinery|api)" || echo "Unable to fetch go.mod"Repository: flanksource/kopper
Length of output: 331
Upgrade controller-runtime to v0.23.x or later for compatibility with k8s.io packages v0.35.2.
controller-runtime v0.22.3 requires k8s.io/client-go and k8s.io/apimachinery v0.34.x, but your go.mod specifies v0.35.2. This version mismatch will cause runtime incompatibilities. Upgrade to controller-runtime v0.23.x or later to support Kubernetes v0.35.x packages.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` around lines 12 - 14, The go.mod entry for
sigs.k8s.io/controller-runtime (currently v0.22.3) is incompatible with
k8s.io/apimachinery and k8s.io/client-go v0.35.2; update the controller-runtime
version to v0.23.0 or later in go.mod (sigs.k8s.io/controller-runtime v0.23.x)
to match Kubernetes v0.35.x, then run go mod tidy and run your unit/integration
tests to ensure no API breaks.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit