Repository navigation
Conversation
Move SQL inspection, capabilities, custom Atlas SQL Server integration, catalog readers, and migration engines into sqlglot-go. Keep commons-db public APIs as typed aliases and forwarding shims, while retaining its generic catalog cache and freshness metadata. Preserve the original SQL Server ParseType, FormatType, ParseRoutine, CreateOrAlter, DefaultDiff, DefaultPlan PlanApplier, routine/definition types, and attribute types. Keep caller-owned database handles, existing migration options, PostgreSQL bundles, SQLite reconciliation, and reviewed SQL Server execution compatible. Pin the published sqlglot-go v1.0.4-0.20261022122245-dc2638100c55 module from flanksource/sqlglot-go#10. Merge that dependency PR first; its native engines own connections, inspection, HCL/script loading, locking, transactions, and SQL execution. Validation: all ten tracked database Gavel fixture gates pass. The isolated PR tree also passes GOWORK=off database API compatibility, SQL inspection, PostgreSQL bundle/view-dependency migrations, Atlas packages, and focused go vet against the published dependency. Regression coverage verifies the original planner symbols and DefaultPlan interface. Native build, lint, PostgreSQL/SQLite reviewed execution, and remote SQL Server runtime/bundle execution pass. Gavel-Issue-Id: e5e4b378-75e4-4291-9c72-585d138a7cef
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Gavel summary
Totals: 121 passed · 0 failed · 0 skipped · 489ms |
Contributor
Gavel summary
Totals: 5361 passed · 0 failed · 57 skipped · 4m17s |
Align root, recordstore, tracing and query modules on the published SQL Server compatibility and Windows SQLite URI fixes from sqlglot-go PR #10. HCL and PostgreSQL parsing are now indirect dependencies owned by the standalone engine, and obsolete sqlglot checksums are removed. Reproduced the CI tidy failure locally; GOWORK=off make tidy-check now passes for all four modules.
Contributor
Gavel summary
Totals: 6 passed · 0 failed · 1 skipped · 1m29s |
Claude-Session-Id: 01a15eea-9e79-7161-890a-03eac0c66cf1
Claude-Session-Id: 01a15eea-9e79-7161-890a-03eac0c66cf1
Claude-Session-Id: 01a15eea-9e79-7161-890a-03eac0c66cf1
Claude-Session-Id: 01a15eea-9e79-7161-890a-03eac0c66cf1
moshloop
added a commit
that referenced
this pull request
Oct 23, 2026
Retain the public type, routine and planner symbols through aliases and forwarding functions, including the DefaultPlan PlanApplier interface. Pin the final published sqlglot PR commit and add API compatibility regression coverage. Validated in the isolated PR with GOWORK=off database compatibility, inspection, PostgreSQL migrations and go vet; linked compatibility also passes. Published as part of commons-db PR #112.
moshloop
added a commit
that referenced
this pull request
Oct 23, 2026
Mirror the verified PR #112 tidy fix in the original checkout. Root, recordstore, tracing and query use the final published sqlglot PR commit; moved HCL and PostgreSQL parser dependencies become indirect. The isolated PR passes make tidy-check for all four modules.
moshloop
added a commit
that referenced
this pull request
Oct 23, 2026
Retain the public type, routine and planner symbols through aliases and forwarding functions, including the DefaultPlan PlanApplier interface. Pin the final published sqlglot PR commit and add API compatibility regression coverage. Validated in the isolated PR with GOWORK=off database compatibility, inspection, PostgreSQL migrations and go vet; linked compatibility also passes. Published as part of commons-db PR #112.
moshloop
added a commit
that referenced
this pull request
Oct 23, 2026
Mirror the verified PR #112 tidy fix in the original checkout. Root, recordstore, tracing and query use the final published sqlglot PR commit; moved HCL and PostgreSQL parser dependencies become indirect. The isolated PR passes make tidy-check for all four modules.
moshloop
added a commit
that referenced
this pull request
Oct 23, 2026
Retain the public type, routine and planner symbols through aliases and forwarding functions, including the DefaultPlan PlanApplier interface. Pin the final published sqlglot PR commit and add API compatibility regression coverage. Validated in the isolated PR with GOWORK=off database compatibility, inspection, PostgreSQL migrations and go vet; linked compatibility also passes. Published as part of commons-db PR #112.
moshloop
added a commit
that referenced
this pull request
Oct 23, 2026
Mirror the verified PR #112 tidy fix in the original checkout. Root, recordstore, tracing and query use the final published sqlglot PR commit; moved HCL and PostgreSQL parser dependencies become indirect. The isolated PR passes make tidy-check for all four modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
github.com/flanksource/sqlglot-gotov1.0.4-0.20261022122245-dc2638100c55.Why
Notes
ParseType,FormatType,ParseRoutine,CreateOrAlter,DefaultDiff, andDefaultPlanPlanAppliersymbols, along with the routine, definition, and attribute types, are preserved.GOWORK=offcompatibility, SQL inspection, PostgreSQL bundle/view-dependency migrations, Atlas packages, and focusedgo vetpass against the published dependency. Native build, lint, PostgreSQL/SQLite reviewed execution, and remote SQL Server runtime/bundle execution pass.