Repository navigation
Conversation
The SQL Server differ, type mapping, routine parsing and migration planner now live in github.com/flanksource/sqlglot-go/migrate/atlas/sqlserver. The commons-db driver keeps catalog inspection, HCL loading, connections, locks, transactions and statement execution, and delegates the pure diff and plan logic to that package. The exported helpers that moved (ParseType, FormatType, ParseRoutine, CreateOrAlter, DefaultDiff, DefaultPlan and the attribute types such as Identity, Clustered and Definition) are removed from atlas/sqlserver. Callers must import the sqlglot-go package instead. BREAKING CHANGE: atlas/sqlserver no longer exports ParseType, FormatType, ParseRoutine, CreateOrAlter, DefaultDiff, DefaultPlan, Identity, DefaultConstraint, Clustered, IndexInclude, IndexPredicate, UniqueConstraint, Definition and Routine. CreateOrAlter now accepts ALTER PROCEDURE/FUNCTION definitions and rewrites them to CREATE OR ALTER, and planning a view without a T-SQL definition fails with a routine-specific error.
Claude-Session-Id: 01a15eea-9e79-7161-890a-03eac0c66cf1
Replace commons-db SQL inspection, capabilities, custom Atlas SQL Server runtime, target parsing, catalog readers, and migration engines with typed sqlglot-go shims. Preserve existing public options and types, caller-owned handles, PostgreSQL bundle behavior, and catalog cache metadata. Move implementation-owned tests with the engine and retain consumer compatibility coverage. Pin sqlglot-go v1.0.4-0.20261022121445-328654b54c0a, the published commit from flanksource/sqlglot-go#10, so the new packages resolve without a local replacement. Merge the sqlglot dependency PR first. Validation: all 10 tracked database Gavel fixture gates pass, including SQLite API/cache compatibility, existing PostgreSQL bundle/view-dependency migrations, and the standalone native engine suite. Unrelated Git, query, and connection changes are excluded from this commit. Gavel-Issue-Id: e5e4b378-75e4-4291-9c72-585d138a7cef
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Gavel summary
Totals: 121 passed · 0 failed · 0 skipped · 481ms |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Gavel crashed before producing resultsExit code: 1 Full |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
github.com/flanksource/sqlglot-go/migrate/atlas/sqlserver.Why
Notes
atlas/sqlserverno longer exportsParseType,FormatType,ParseRoutine,CreateOrAlter,DefaultDiff,DefaultPlan, and the attribute types. Callers must import the sqlglot-go package instead.CreateOrAlternow accepts ALTER PROCEDURE/FUNCTION definitions and rewrites them to CREATE OR ALTER.sqlglot-gotov1.0.4-0.20261022121445-328654b54c0a(feat: standalone inspect and migrate sqlglot-go#10). Merge the sqlglot dependency PR first.