Conversation
Remove drawingHelper parameter from TableComponent.drawCellText calls to match the actual method signature (3 parameters instead of 4). This fixes the TestTwoColumnSVGTableLayout test compilation errors.
- Add Point, MM, FontSize, and Rem types with conversion methods - Fix critical unit mismatch in getRowHeight() where font size points were treated as MM - Update style converter to use proper unit conversions instead of magic numbers - Replace hardcoded conversion factors (6, 4, 12) with accurate constants - Add comprehensive unit conversion constants: PointsToMM, MMToPoints, RemToPoints, RemToMM - Update FPDF interface documentation to clarify unit expectations - All tests pass with precise conversion accuracy This resolves font metrics (points) vs layout dimensions (MM) mixing that caused incorrect row height calculations in table rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.