feat(templates): extend TemplatePayload bound to CONFIG type parameter#853
Merged
feat(templates): extend TemplatePayload bound to CONFIG type parameter#853
Conversation
The APPLY and ROLLBACK type parameters already enforced `extends TemplatePayload`, but CONFIG remained unbounded — preventing load-time validation of configuration payloads. This change completes the contract across all three template generics. Public API: - **ChangeTemplate** and **AbstractChangeTemplate** now require `CONFIG extends TemplatePayload` - **TemplateVoid** sentinel replaces `Void` for templates with no configuration, implementing TemplatePayload with a no-op validate() Load-time CONFIG conversion: - **TemplateLoadedTaskBuilder** now converts CONFIG from raw YAML data to typed TemplatePayload at load time, consistent with APPLY/ROLLBACK conversion - Dead `Void.class` guard checks removed from convertPayloads() and convertSteps() Validation: - **SimpleTemplateLoadedChange** and **MultiStepTemplateLoadedChange** implement validateConfigurationPayload(), calling config.validate() at pipeline load time Executable task simplification: - **AbstractTemplateExecutableTask.setConfigurationData()** no longer re-converts the already-typed config; uses TemplateVoid.class sentinel instead of Void.class Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The APPLY and ROLLBACK type parameters already enforced
extends TemplatePayload,but CONFIG remained unbounded — preventing load-time validation of configuration
payloads. This change completes the contract across all three template generics.
Public API:
CONFIG extends TemplatePayloadVoidfor templates with no configuration,implementing TemplatePayload with a no-op validate()
Load-time CONFIG conversion:
TemplatePayload at load time, consistent with APPLY/ROLLBACK conversion
Void.classguard checks removed from convertPayloads() and convertSteps()Validation:
validateConfigurationPayload(), calling config.validate() at pipeline load time
Executable task simplification:
the already-typed config; uses TemplateVoid.class sentinel instead of Void.class