Skip to content

perf: Skip lifecycle processing work when the queue is empty #3978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spydon merged 3 commits into from
Aug 16, 2026
+11 −3
Merged

perf: Skip lifecycle processing work when the queue is empty #3978

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53903bd
perf: Skip lifecycle processing work when the queue is empty
spydon Aug 5, 2026
d9f1d71
refactor: Address review feedback on the empty-queue early-out
spydon Aug 5, 2026
29a82f1
Apply suggestion from @spydon
spydon Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions packages/flame/lib/src/components/core/component_tree_root.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,18 @@ class ComponentTreeRoot extends Component {
}

void processLifecycleEvents() {
if (!hasLifecycleEvents) {
assert(
_lifecycleEventsCompleter == null,
'The completer is only ever created while events are queued, so it '
'should never exist while the queue is empty',
);
return;
}
// reorder events to process later grouped by parent
final reorderParents = <Component>{};
Set<Component>? reorderParents;
LifecycleEventStatus handleReorderEvent(Component parent) {
reorderParents.add(parent);
(reorderParents ??= {}).add(parent);
return LifecycleEventStatus.done;
}

Expand Down Expand Up @@ -182,7 +190,7 @@ class ComponentTreeRoot extends Component {
_blocked.clear();
}

for (final parent in reorderParents) {
for (final parent in reorderParents ?? const <Component>{}) {
parent.rebalanceChildren();
}

Expand Down
Loading