fix: Reimplement setLayoutSize to only notify once #3796
Merged
+55
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livtanong
changed the title
spydon
approved these changes
Jan 6, 2026
Member
spydon
left a comment
spydon
left a comment
There was a problem hiding this comment.
Lgtm, except the commented out code
Thanks for your fix!
packages/flame/test/experimental/linear_layout_component_test.dart
Outdated
Show resolved
Hide resolved
Member
|
Fixed the failing pipeline step in #3797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases, like when a PaddingComponent with inflateChild = true wraps a ColumnComponent, we get a stack overflow.
This is because
setLayoutSizewas implemented assetLayoutAxisLengthon both axes. At first glance, this seems equivalent, but the first invocation would trip all size listeners before the second invocation completes. This meant that the guard statement ofSingleChildLayoutComponent.syncChildSizewould never execute in the case of aPaddingComponentwithinflateChildset to true wrapping the LayoutComponent. Thus, infinite loop.This PR fixes the implementation of both
setLayoutSizeandresetSize.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues