Skip to content

Conversation

@Wilhansen
Copy link
Contributor

@Wilhansen Wilhansen commented Dec 8, 2025

Description

Addresses issue #3786 by adding a new function TextBoxComponent::rewind.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #3786

@Wilhansen Wilhansen changed the title feat: add TextBoxComponent::rewind Feat: add TextBoxComponent::rewind Dec 8, 2025
@Wilhansen Wilhansen force-pushed the feat-add-rewind-textboxcomponent branch from bad059c to 0c3aa36 Compare December 8, 2025 09:29
@Wilhansen Wilhansen changed the title Feat: add TextBoxComponent::rewind feat: Add TextBoxComponent::rewind Dec 8, 2025
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests and docs are missing

Enables resetting of the typewriter animation of the TextBoxComponent.
Useful for changing lines without having to re-insert the component into
the scene node, which causes undesired flashing.
@Wilhansen Wilhansen force-pushed the feat-add-rewind-textboxcomponent branch from f1e6d0e to e009ff1 Compare December 18, 2025 09:22
@spydon spydon changed the title feat: Add TextBoxComponent::rewind feat: Add TextBoxComponent.resetAnimation Dec 19, 2025
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs for the site is still missing, otherwise it looks good

@Wilhansen
Copy link
Contributor Author

Docs for the site is still missing, otherwise it looks good

Added site docs, also included mention of skip.

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for your contribution

@spydon spydon enabled auto-merge (squash) December 23, 2025 09:09
@spydon spydon merged commit 33fb10c into flame-engine:main Dec 23, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement "rewind" function for TextBoxComponent

2 participants