-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: Add TextBoxComponent.resetAnimation #3787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add TextBoxComponent.resetAnimation #3787
Conversation
bad059c to
0c3aa36
Compare
spydon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests and docs are missing
Enables resetting of the typewriter animation of the TextBoxComponent. Useful for changing lines without having to re-insert the component into the scene node, which causes undesired flashing.
f1e6d0e to
e009ff1
Compare
spydon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs for the site is still missing, otherwise it looks good
Added site docs, also included mention of |
spydon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks for your contribution
Description
Addresses issue #3786 by adding a new function
TextBoxComponent::rewind.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #3786