-
-
Notifications
You must be signed in to change notification settings - Fork 30
Expose Ingestion API with Inversion of Control #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marvin-j97
merged 25 commits into
fjall-rs:main
from
zaidoon1:zaidoon/ingestion-api-inversion-control
Nov 23, 2025
Merged
Expose Ingestion API with Inversion of Control #191
marvin-j97
merged 25 commits into
fjall-rs:main
from
zaidoon1:zaidoon/ingestion-api-inversion-control
Nov 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-j97
requested changes
Nov 8, 2025
marvin-j97
reviewed
Nov 8, 2025
marvin-j97
reviewed
Nov 8, 2025
marvin-j97
reviewed
Nov 9, 2025
a043736 to
14ef584
Compare
Contributor
|
I'm currently massively simplifying the flush logic such that is gets really easy to flush active and sealed memtables in one go by just calling |
marvin-j97
reviewed
Nov 11, 2025
Contributor
|
(Forgot to submit comments) But as I said, I am currently changing the Flush API which should make the ingestion API much simpler. (WIP at #194) |
marvin-j97
reviewed
Nov 11, 2025
1af202a to
87c7d03
Compare
87c7d03 to
36b2651
Compare
marvin-j97
reviewed
Nov 15, 2025
marvin-j97
reviewed
Nov 15, 2025
marvin-j97
reviewed
Nov 15, 2025
marvin-j97
requested changes
Nov 15, 2025
…n-control' into zaidoon/ingestion-api-inversion-control
…n-control' into zaidoon/ingestion-api-inversion-control
marvin-j97
reviewed
Nov 22, 2025
marvin-j97
approved these changes
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #190