Repository navigation
deps: pin sdl_zig fizzy-1.0.3+3.4.16-9, the Wayland frame-inset fixes - #314
Merged
Merged
Conversation
SDL fizzy-3.4.16-9 fixes six problems in patch 6 (Wayland frame insets): insets lost when SDL makes a window again, an opaque window's opaque region covering its shadow, the toplevel bounds clamped by the surface rather than the frame, a hard-coded input band (now a creation property, default 8), insets published only after show, and a window shown again losing its frame. Each but the bounds clamp has an assertion that fails without its fix. fizzy's own use is unchanged. DEPENDENCIES.md records the fixes, the suite's new checks, sdl_zig's CI change, both tags, and upstream main's own version of the feature to move to at the next rebase. Part of #280. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 of 5 tasks
foxnne
marked this pull request as ready for review
October 10, 2026 00:51
7 of 23 tasks
foxnne
added a commit
that referenced
this pull request
Oct 10, 2026
The move redone on main: #309's Health.zig and its test, #314's SDL pin (now in backend/build.zig.zon) and #315's Linux edits come along into backend/. The platform's Objective-C is linked into the executable again (addPlatformObjC), not carried by the platform module: it calls back into the platform's Zig, which #309's test of the backend alone never reaches, so that test failed to link. Drops the .sb/ sandbox profile this branch had picked up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #280 (step C2b landed on the forks).
Moves fizzy's
.sdlpin to sdl_zigfizzy-1.0.3+3.4.16-9(SDLfizzy-3.4.16-9), which fixes six problems in SDL patch 6 (Wayland frame insets, the margins fizzy draws its Linux window shadow in):92582880ca75f20426af9SDL_PROP_WINDOW_CREATE_WAYLAND_FRAME_INPUT_MARGIN_NUMBER(default 8)91b7a29883f5c8011a2dcFork PRs: fizzyedit/SDL#4 →
fizzy-3.4.16-9, fizzyedit/sdl_zig#4 →fizzy-1.0.3+3.4.16-9.Fizzy's own use (
linux_titlebar.zig) is unchanged: it keeps the default band, and its insets now also survive a recreate.For later: upstream SDL
maingained its own version of frame insets on 2026-09-24. It isn't inrelease-3.4.x, and it has none of these fixes.docs/DEPENDENCIES.mdnow says to move fizzy to upstream's API at the rebase onto a release that has it, keeping only what upstream lacks as patches.#312 overlaps: it moves this pin from the root
build.zig.zonintobackend/build.zig.zon. Whichever PR lands second carries the-9pin into the other's location.Verified
On macOS (arm64), in a fresh workspace on
main:zig buildzig build testzig build test-integrationzig build check-webzig build test-sdk-versionzig build -Dtarget=x86_64-linux-gnuNot verified: the fixes on a real GNOME desktop with fizzy itself. The evidence is the fork's suite under headless weston. The SDK fingerprint doesn't move, since plugins never link SDL.
🤖 Generated with Claude Code