Repository navigation
deps: SDL forks carry tests, and Wayland loads on older libxkbcommon - #294
Merged
Merged
Conversation
foxnne
force-pushed
the
deps/sdl-fork-tests
branch
from
October 9, 2026 18:52
3f29576 to
24dcfce
Compare
7 of 23 tasks
Pins sdl_zig fizzy-1.0.3+3.4.16-8 (SDL fizzy-3.4.16-8). fizzyedit/SDL now carries fizzy's own test suites beside its patches, and fizzyedit/sdl_zig a `zig build test-fizzy` step that runs them in CI. The new pin also takes SDL patch 8: built against libxkbcommon 1.10+ headers, SDL required `xkb_keymap_mod_get_mask()`, so on Ubuntu 24.04 (1.6) or Debian 12 (1.5) the Wayland driver reported itself unavailable and fizzy fell back to X11. The symbol is now optional at runtime, with SDL's existing fallback for the masks. A suite proves it: red on ubuntu:24.04 without the patch, green on 24.04 and 26.04 with it. DEPENDENCIES.md records patch 8, the three suites (patches 1, 8 and 6), sdl_zig's step and jobs, and the tags. Fixes #289. Part of #280. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
foxnne
force-pushed
the
deps/sdl-fork-tests
branch
from
October 9, 2026 19:20
24dcfce to
968f022
Compare
foxnne
marked this pull request as ready for review
October 9, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #289. Part of #280 (steps A1, A2 and A4b landed on the forks).
Moves fizzy's
.sdlpin to sdl_zigfizzy-1.0.3+3.4.16-8(SDLfizzy-3.4.16-8). That brings two things:1. The forks carry tests now. fizzyedit/SDL has fizzy's own suites on SDL's test harness, one per patch, each failing without its patch. fizzyedit/sdl_zig runs them with
zig build test-fizzyin CI: Linux on lavapipe under Xvfb and headless weston, and the hosted macOS runners, which have a Metal device.fizzy-3.4.16-6(4839ede): the runner, plus patch 1's suite (transparent window claimed on Metal and Vulkan).fizzy-1.0.3+3.4.16-6(0f6a2a8): thetest-fizzystep.fizzy-3.4.16-8(a518aaf), ci: run the Wayland frame-insets suite under headless weston sdl_zig#2 →fizzy-1.0.3+3.4.16-8(a02dda8): patch 6's suite, Wayland frame insets.2. SDL patch 8: Wayland loads where libxkbcommon is older than 1.10 (#289).
xkb_keymap_mod_get_mask(). On Ubuntu 24.04 (1.6) or Debian 12 (1.5) the whole Wayland driver reported itself unavailable, and fizzy fell back to X11. Upstreammainhas the same problem.xkb_keymap_mod_get_index(), the path SDL already takes when built against older headers. For standard keymaps both paths give the same masks.ubuntu:24.04without the patch ("wayland not available");fizzy-3.4.16-7(36dda37); test: run the Wayland keyboard suite on Ubuntu 24.04 and 26.04 sdl_zig#3 →fizzy-1.0.3+3.4.16-7(264af2a).docs/DEPENDENCIES.mdrecords patch 8, the three suites, sdl_zig's step and CI jobs, all six tags, and each patch's check at a rebase.Verified
On macOS (arm64), in a fresh workspace on
main:zig buildzig build testzig build test-integrationzig build check-webzig build test-sdk-versionzig build -Dtarget=x86_64-linux-gnuNot verified: a fizzy binary running on a real Ubuntu 24.04 Wayland desktop. The evidence is the fork suite in CI containers, built from the same sdl_zig. The SDK fingerprint doesn't move, since plugins never link SDL.
🤖 Generated with Claude Code