Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new moq-demo web demo app for MoQ livestreaming (publisher + viewer) using Vite + SolidJS + Tailwind, including a custom Vite plugin for inlining AudioWorklet modules.
Changes:
- Introduce a new SolidJS UI with Streamer and Viewer panels that connect via Fishjam Cloud.
- Add Vite/Tailwind/TypeScript configuration for building and running the demo.
- Add a custom
?workletVite plugin for bundling and inlining worklet code.
Reviewed changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| moq-demo/package.json | Defines demo dependencies and scripts (dev/build/check/format). |
| moq-demo/yarn.lock | Lockfile for deterministic installs of demo dependencies. |
| moq-demo/vite.config.ts | Vite config (Solid plugin, Tailwind, worklet plugin, build/server settings). |
| moq-demo/vite-plugin-worklet.ts | Custom Vite plugin to inline ?worklet imports as blob URLs. |
| moq-demo/tsconfig.json | TypeScript compiler configuration for the demo. |
| moq-demo/src/vite-env.d.ts | Solid JSX typings for custom moq-* elements. |
| moq-demo/src/index.html | Demo HTML entrypoint. |
| moq-demo/src/index.tsx | Solid app bootstrap. |
| moq-demo/src/index.css | Tailwind setup + theme variables/base styles. |
| moq-demo/src/App.tsx | Main layout and stream name input; wires Streamer/Viewer. |
| moq-demo/src/Streamer.tsx | Publisher UI that fetches a token and configures <moq-publish>. |
| moq-demo/src/Viewer.tsx | Subscriber UI that fetches a token and configures <moq-watch>. |
| moq-demo/README.md | Local run instructions and URL format for Fishjam room IDs. |
| .gitignore | Ignores .claude. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Karolk99
force-pushed
the
fce-3165/moq-web-demo
branch
from
de48d15 to
8d03ab6
Compare
PiotrWodecki
left a comment
PiotrWodecki
left a comment
There was a problem hiding this comment.
I've placed all of my feedback as file comments so they can be resolved separately. Imho, simply fixing the blocking issue is fine for now. Approving preemptively.
There was a problem hiding this comment.
issue (blocking):
Audio has no latency bar despite being enabled and working
There was a problem hiding this comment.
issue (if-minor):
This button seems not to work at all
There was a problem hiding this comment.
All of the problems mentioned about the subscriber player are internal problems of the imported player.
They will be addressed in another PR Issue
There was a problem hiding this comment.
nitpick (non-blocking): No latency bar when playing back from a file
There was a problem hiding this comment.
nitpick (non-blocking):
Play/pause button could have two states instead of always displaying "play"
No description provided.