Skip to content

Pass callNodeInfo to handleCallNodeTransformShortcut. #6115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mstange merged 2 commits into from
Jun 23, 2026
+5 −4
Merged

Pass callNodeInfo to handleCallNodeTransformShortcut. #6115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1dd4b1
Pass callNodeInfo to handleCallNodeTransformShortcut.
mstange Jun 21, 2026
2cfc425
Merge branch 'main' into push-txtmsmxrmyqq
mstange Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/actions/profile-view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2015,6 +2015,7 @@ export function toggleBottomBoxFullscreen(): ThunkAction<void> {
export function handleCallNodeTransformShortcut(
event: React.KeyboardEvent<HTMLElement>,
threadsKey: ThreadsKey,
callNodeInfo: CallNodeInfo,
callNodeIndex: IndexIntoCallNodeTable
): ThunkAction<void> {
return (dispatch, getState) => {
Expand All @@ -2023,7 +2024,6 @@ export function handleCallNodeTransformShortcut(
}
const threadSelectors = getThreadSelectorsFromThreadsKey(threadsKey);
const unfilteredThread = threadSelectors.getThread(getState());
const callNodeInfo = threadSelectors.getCallNodeInfo(getState());
const implementation = getImplementationFilter(getState());
const inverted = getInvertCallstack(getState());
const callNodePath = callNodeInfo.getCallNodePathFromIndex(callNodeIndex);
Expand Down
3 changes: 2 additions & 1 deletion src/components/calltree/CallTree.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@ class CallTreeImpl extends PureComponent<Props> {
rightClickedCallNodeIndex,
handleCallNodeTransformShortcut,
threadsKey,
callNodeInfo,
} = this.props;
const nodeIndex =
rightClickedCallNodeIndex !== null
Expand All @@ -284,7 +285,7 @@ class CallTreeImpl extends PureComponent<Props> {
if (nodeIndex === null) {
return;
}
handleCallNodeTransformShortcut(event, threadsKey, nodeIndex);
handleCallNodeTransformShortcut(event, threadsKey, callNodeInfo, nodeIndex);
};

_onEnterOrDoubleClick = (nodeId: IndexIntoCallNodeTable) => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/flame-graph/FlameGraph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ class FlameGraphImpl
return;
}

handleCallNodeTransformShortcut(event, threadsKey, nodeIndex);
handleCallNodeTransformShortcut(event, threadsKey, callNodeInfo, nodeIndex);
};

_onCopy = (event: ClipboardEvent) => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/stack-chart/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ class StackChartImpl extends React.PureComponent<Props> {
return;
}

handleCallNodeTransformShortcut(event, threadsKey, nodeIndex);
handleCallNodeTransformShortcut(event, threadsKey, callNodeInfo, nodeIndex);
};

_onDoubleClick = (callNodeIndex: IndexIntoCallNodeTable | null) => {
Expand Down
Loading