-
Notifications
You must be signed in to change notification settings - Fork 469
Migrate from prettier to oxfmt #5986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "$schema": "./node_modules/oxfmt/configuration_schema.json", | ||
| "singleQuote": true, | ||
| "trailingComma": "es5", | ||
| "endOfLine": "lf", | ||
| "printWidth": 80, | ||
| "sortPackageJson": false, | ||
| "ignorePatterns": [ | ||
| "src/profile-logic/import/proto", | ||
| "src/types/libdef/npm", | ||
| "docs-user/js", | ||
| "docs-user/css", | ||
| "src/test/fixtures/upgrades", | ||
| "dist", | ||
| "coverage", | ||
| "taskcluster/", | ||
| ".taskcluster.yml" | ||
| ] | ||
| } | ||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,6 @@ import jestPlugin from 'eslint-plugin-jest'; | |
| import testingLibraryPlugin from 'eslint-plugin-testing-library'; | ||
| import jestFormattingPlugin from 'eslint-plugin-jest-formatting'; | ||
| import jestDomPlugin from 'eslint-plugin-jest-dom'; | ||
| import prettierConfig from 'eslint-config-prettier'; | ||
| import globals from 'globals'; | ||
|
|
||
| export default defineConfig( | ||
|
|
@@ -35,11 +34,6 @@ export default defineConfig( | |
| // React config | ||
| reactPlugin.configs.flat.recommended, | ||
|
|
||
| // Prettier config must be placed here to disable formatting rules from the | ||
| // base configs above, while allowing our custom rules below to take | ||
| // precedence. | ||
| prettierConfig, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. eslint-config-prettier essentially disables a bunch of formatting rules that might clash with the prettier formatting. I wonder if we need something for oxfmt too, but I think it's fine if it didn't clash already after the migration. |
||
|
|
||
| // Custom configuration for all files | ||
| { | ||
| files: ['**/*.js', '**/*.mjs', '**/*.cjs', '**/*.ts', '**/*.tsx'], | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| [context.l10n] | ||
| command = "yarn build-l10n-prod" | ||
| command = "yarn build-l10n-prod" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, we added
profiler-cli/distto the prettierignore while adding the profiler cli. We should add it here too.