-
Notifications
You must be signed in to change notification settings - Fork 469
Update isLocalURL to include LAN addresses, .local domains, and hostn… #5973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cathaysia
wants to merge
4
commits into
firefox-devtools:main
Choose a base branch
from
cathaysia:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+120
−2
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
11f8b4c
Update isLocalURL to include LAN addresses, .local domains, and hostn…
cathaysia 8ee35b3
Update isLocalURL to include IPv6 local addresses (Link-local and ULA)
cathaysia 7e1b79c
Further expand isLocalURL to include CGNAT, IPv4 link-local, and benc…
cathaysia 7b3c2f1
Apply suggestion
cathaysia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import { isLocalURL } from 'firefox-profiler/utils/url'; | ||
|
|
||
| describe('isLocalURL', () => { | ||
| it('should return true for localhost', () => { | ||
| expect(isLocalURL('http://localhost')).toBe(true); | ||
| expect(isLocalURL('http://localhost:3000')).toBe(true); | ||
| }); | ||
|
|
||
| it('should return true for 127.0.0.1', () => { | ||
| expect(isLocalURL('http://127.0.0.1')).toBe(true); | ||
| }); | ||
|
|
||
| it('should return true for ::1', () => { | ||
| expect(isLocalURL('http://[::1]')).toBe(true); | ||
| }); | ||
|
|
||
| it('should return true for IPv6 local addresses', () => { | ||
| expect(isLocalURL('http://[fe80::1]')).toBe(true); | ||
| expect(isLocalURL('http://[fd00::1]')).toBe(true); | ||
| expect(isLocalURL('http://[fc00::1]')).toBe(true); | ||
|
cathaysia marked this conversation as resolved.
|
||
| expect(isLocalURL('http://[ff00::1]')).toBe(false); | ||
| expect(isLocalURL('http://[::ffff:1.1.1.1]')).toBe(false); | ||
| }); | ||
|
|
||
| it('should return true for LAN addresses', () => { | ||
| expect(isLocalURL('http://10.0.0.1')).toBe(true); | ||
| expect(isLocalURL('http://10.255.255.255')).toBe(true); | ||
| expect(isLocalURL('http://172.16.0.1')).toBe(true); | ||
| expect(isLocalURL('http://172.31.255.255')).toBe(true); | ||
| expect(isLocalURL('http://192.168.1.1')).toBe(true); | ||
| expect(isLocalURL('http://100.100.100.100')).toBe(true); | ||
| expect(isLocalURL('http://169.254.1.1')).toBe(true); | ||
| expect(isLocalURL('http://198.18.0.1')).toBe(true); | ||
| expect(isLocalURL('http://127.0.0.2')).toBe(true); | ||
| }); | ||
|
|
||
| it('should return false for other public IP addresses', () => { | ||
| expect(isLocalURL('http://8.8.8.8')).toBe(false); | ||
| expect(isLocalURL('http://172.15.255.255')).toBe(false); | ||
| expect(isLocalURL('http://172.32.0.0')).toBe(false); | ||
| }); | ||
|
|
||
| it('should return true for .local domains', () => { | ||
| expect(isLocalURL('http://myserver.local')).toBe(true); | ||
| expect(isLocalURL('http://test.local:8080')).toBe(true); | ||
| }); | ||
|
|
||
| it('should return true for hostnames without dots', () => { | ||
| expect(isLocalURL('http://mycomputer')).toBe(true); | ||
| expect(isLocalURL('http://dev-server:8000')).toBe(true); | ||
| }); | ||
|
|
||
| it('should return false for public domains', () => { | ||
| expect(isLocalURL('https://firefox.com')).toBe(false); | ||
| expect(isLocalURL('https://profiler.firefox.com')).toBe(false); | ||
| }); | ||
|
|
||
| it('should return false for invalid URLs', () => { | ||
| expect(isLocalURL('not-a-url')).toBe(false); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.