Add experimental sampling interval tracks per process #5719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new experimental feature to visualize sampling intervals within each process. This helps identify when samples were missed, delayed, or when there are variations in sampling frequency. The feature is similar to experimental.enableProcessCPUTracks() and can be enabled via the console with: experimental.enableSamplingIntervalTracks() Implementation details: - Add 'sampling-interval' LocalTrack type - Create TrackSamplingInterval and TrackSamplingIntervalGraph components - Implement canvas rendering with max-min decimation optimization - Add hover tooltips showing actual vs expected sampling intervals - Include hover dot indicator for currently inspected sample
Contributor
Author
|
Screenshot of a case where this helped figure out that there was a connection between spikes in the power track and changes in sampling rate: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5719 +/- ##
==========================================
- Coverage 85.62% 84.93% -0.70%
==========================================
Files 312 315 +3
Lines 30880 31288 +408
Branches 8504 8511 +7
==========================================
+ Hits 26441 26574 +133
- Misses 4009 4284 +275
Partials 430 430 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new experimental feature to visualize sampling intervals within each process. This helps identify when samples were missed, delayed, or when there are variations in sampling frequency.
The feature is similar to experimental.enableProcessCPUTracks() and can be enabled via the console with:
experimental.enableSamplingIntervalTracks()
Implementation details:
Example power profile where I was interested in seeing inconsistencies in sampling rate from the power meter: https://share.firefox.dev/48U79KE
Example Firefox profile with lots of missing samples: https://share.firefox.dev/4p5d8mc