Use workbox-cli to generate the service worker #5681
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5681 +/- ##
=======================================
Coverage 85.62% 85.62%
=======================================
Files 312 312
Lines 30875 30879 +4
Branches 8507 8501 -6
=======================================
+ Hits 26436 26440 +4
Misses 4009 4009
Partials 430 430 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
Hmm, can you tell me more about the reason why this was needed? I think code-wise it looks good to me, but I want to understand the motivation behind it, because I feel like workbox-webpack-plugin is a more convenient way to use workbox as long as there is no strong need for it (also npm download numbers show that the webpack plugin is way more popular than the cli). One thing I suspect is the pq cli tool?
| "build-prod:quiet": "yarn build:clean && yarn build-photon && cross-env NODE_ENV=production webpack && yarn build-sw", | ||
| "build-prod": "yarn build:clean && yarn build-photon && cross-env NODE_ENV=production webpack --progress && yarn build-sw", |
There was a problem hiding this comment.
Hmm, we need to call build-sw at the end because it depends on the webpack outputs, right?
Oh, sorry, I forgot to mention: I pulled this out of the esbuild PR (#5589 ) because it's something that can land separately. esbuild doesn't have a workbox plugin, as far as I know. |
|
I've tested the deploy preview and everything appears to work offline. 
I've also checked the cache storage devtools panel and the cache storage contents look correct. The Status column appears to be completely empty though, I'm not sure why that is, but it currently seems to be that way on the production instance too. I thought I remembered seeing "OK" in some of the cells before but I can't reproduce that at the moment.
|
|
Great, thanks for the context and confirming that it works.
Yeah, I can also see that my production has empty status too. I think it's fine. LGTM! |
Changes: [Markus Stange] Use a longer test timeout when debugging with VS code. (#5679) [Markus Stange] Move Jest config from package.json to jest.config.js (#5680) [Markus Stange] Make binary profile format parsing use Uint8Array instead of ArrayBuffer (#5678) [Markus Stange] Use workbox-cli to generate the service worker (#5681) [Nazım Can Altınova] Migrate from Appveyor to GitHub Actions Windows runners (#5660) [Nazım Can Altınova] Remove some unused dependencies (#5696) [Nazım Can Altınova] Update the document links and sections (#5705) [Nazım Can Altınova] Clear selected and expanded call node paths on browser back button if it removes transforms (#5701) [Nazım Can Altınova] Properly type the Map and Set objects (#5623) [Valentin Gosu] Add priorityHeader field to network requests (#5707) [Nazım Can Altınova] Redirect unpublished url loads to the homepage similar to from-file (#5712) [Florian Quèze/Nazım Can Altınova] Add an importer for the text format taken as input by flamegraph.pl. (#5359) [Florian Quèze] Improve the import of profiles generated from clang -ftime-trace=file.json (#5714) [Markus Stange] Move React stuff out of marker schema logic module. (#5720) And thanks to our localizers: en-CA: chutten en-CA: Paul es-CL: ravmn fr: Théo Chevalier fur: Fabio Tomat ru: berry tr: Selim Şumlu zh-CN: Olvcpr423 zh-CN: wxie
2 participants
Production | Deploy preview
This replaces the webpack plugin with an invocation of the
workboxCLI binary.