Make idp product-agnostic: remove UserRoleEnum + partyId/userRole#13
Merged
Conversation
added 2 commits
June 18, 2026 21:48
…ork) Delete UserRoleEnum (AGENT/SUPER_AGENT/DISTRIBUTOR/ADMIN) and remove the partyId/userRole fields from CreateUserRequest and IntrospectionResponse. Product-specific identity attributes are now carried generically via the attributes map. Part of the fireflyframework-security platform; BREAKING.
…ication/TokenIntrospection/UserAdmin/RoleScope/Session/Mfa) with NotSupported defaults; IdpAdapter is now their aggregate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes firefly-oss product-family domain leakage from the framework so the IdP tier is fully generic.
UserRoleEnum(AGENT/SUPER_AGENT/DISTRIBUTOR/ADMIN business roles).partyIdanduserRolefromCreateUserRequestandIntrospectionResponse; product attributes now flow through the genericattributesmap.Part of the new fireflyframework-security hexagonal platform. BREAKING (clean break, no shims). Do not merge yet — review only.