Fix CI: remove stray package-lock.json, reformat setup.ts - #208
Merged
Conversation
… prettier package-lock.json was accidentally committed in #206 (an npm install artifact — this repo is pnpm-managed). bun prefers it over pnpm-lock.yaml in release-binaries, and its migration fails under --frozen-lockfile. Remove it and gitignore it. setup.ts was formatted by prettier 3.9.6 from that same npm node_modules; CI pins 3.7.4 via pnpm-lock.yaml. Reformatted with 3.7.4. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes both failures from the 1.23.0 release push (npm publish itself succeeded — 1.23.0 is live).
Release Binaries failure: #206 accidentally committed a
package-lock.json(an npm-install artifact; the repo is pnpm-managed). bun preferspackage-lock.jsonoverpnpm-lock.yamlwhen both exist, and migrating the stale npm lockfile fails under--frozen-lockfile. The passing 1.22.0 run migrated frompnpm-lock.yaml; the failing 1.23.0 run frompackage-lock.json— same bun 1.4.0. Removed and gitignored.Test failure:
setup.tshad been formatted by prettier 3.9.6 (from that same npmnode_modules) while CI pins 3.7.4 viapnpm-lock.yaml. Reformatted with the pinned 3.7.4;format:checknow passes on the whole tree.Verified locally:
bun install --frozen-lockfilecompletes,prettier --checkclean, 431/431 tests pass.After merging: Release Binaries won't auto-trigger (its path filter watches
package.json) — dispatch it once to build the 1.23.0 binaries:gh workflow run release-binaries.yml --repo firecrawl/cli🤖 Generated with Claude Code
Summary by cubic
Fixes CI by removing an accidental
package-lock.json, adding it to.gitignore, and reformattingsrc/commands/setup.tswith the pinnedprettier@3.7.4.bunpreviously preferredpackage-lock.jsonoverpnpm-lock.yamland failed--frozen-lockfilemigration; now it migrates frompnpm-lock.yamlandformat:checkpasses.gh workflow run release-binaries.yml --repo firecrawl/clito build the 1.23.0 binaries.Written for commit e95ab8e. Summary will update on new commits.