chore(*): remove obsolete flags from gradle.properties#2811
chore(*): remove obsolete flags from gradle.properties#2811thatfiredev wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates resource references to use fully qualified names across multiple instrumented tests and sets android.nonTransitiveRClass and android.nonFinalResIds to true in gradle.properties. Feedback suggests completely removing these obsolete Gradle flags from gradle.properties instead of setting them to true to keep the configuration clean.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates several instrumented tests to use fully-qualified resource IDs from androidx.appcompat and Firebase In-App Messaging, while also removing some AndroidX and R-class configuration properties from gradle.properties. The reviewer feedback suggests improving code readability across the test files by using static imports for these long, fully-qualified resource IDs instead of referencing them inline.
| withParent(allOf(withId(R.id.select_dialog_listview), | ||
| withParent(withId(R.id.contentPanel)))), | ||
| withParent(allOf(withId(androidx.appcompat.R.id.select_dialog_listview), | ||
| withParent(withId(androidx.appcompat.R.id.contentPanel)))), |
There was a problem hiding this comment.
Can we import all libraries at the beginning of the class, instead of inside the functions? (Same comment for all 3 test files in this PR).
2 participants
All of these flags default to true in AGP 9.0 and are safe to remove.