Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
MichaelDoyle
force-pushed
the
fix-build
branch
from
39410b0 to
909e841
Compare
MichaelDoyle
force-pushed
the
fix-build
branch
from
909e841 to
f2a29f4
Compare
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses the build failure by upgrading the TypeScript version in the plugins/vertexai package and resolves package export warnings by reordering the types condition in package.json. The changes are straightforward and align with best practices for modern Node.js packages. The update to pnpm-lock.yaml is consistent with these dependency changes. Overall, this is a solid fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed build failure in @genkit-ai/vertexai caused by TypeScript version incompatibility with transitive zod
dependencies, and resolved related package export warnings.