refactor(plugins/compat-oai): use ChatCompletionAccumulator for strea… #3870
+110
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eric642
commented
Dec 2, 2025
eric642
commented
- Simplified generateStream by using openai-go's ChatCompletionAccumulator
- Removed manual tool call accumulation logic (currentToolCall, toolCallCollects)
- Created convertChatCompletionToModelResponse helper for unified response conversion
- Added support for detailed token usage fields:
- ThoughtsTokens (reasoning tokens)
- CachedContentTokens (cached tokens)
- Audio, prediction tokens in custom field
- Added support for refusal messages and system fingerprint metadata
- Refactored generateComplete to reuse convertChatCompletionToModelResponse
…ming - Simplified generateStream by using openai-go's ChatCompletionAccumulator - Removed manual tool call accumulation logic (currentToolCall, toolCallCollects) - Created convertChatCompletionToModelResponse helper for unified response conversion - Added support for detailed token usage fields: - ThoughtsTokens (reasoning tokens) - CachedContentTokens (cached tokens) - Audio, prediction tokens in custom field - Added support for refusal messages and system fingerprint metadata - Refactored generateComplete to reuse convertChatCompletionToModelResponse
Contributor
Author
|
@apascal07 @hugoaguirre pls review it. |
Collaborator
|
@hugoaguirre Take a first pass at this please, test it and make sure everything works. |
Contributor
|
Hi @eric642, I think you might need to resolve the CLA for the rest of the contributors in the last commit. |
apascal07
approved these changes
Dec 4, 2025
Collaborator
apascal07
left a comment
apascal07
left a comment
There was a problem hiding this comment.
LGTM but I'm less familiar with this code, @hugoaguirre to verify.
Remove unused conditional check and commented code in streaming logic.
eric642
force-pushed
the
refactor_plugins_compat_oai
branch
from
debae59 to
48cd657
Compare
Contributor
Author
|
@hugoaguirre Sorry, I need you to re-review this. Previously, there was a commit message that was generated directly by Claude. The anthropic email address was mistakenly entered, resulting in a pending status for Claude. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.