Skip to content

[Remote Config] Add Custom Signals - #1503

Merged
a-maurice merged 6 commits into
mainfrom
am-custom_signals
Aug 18, 2026
Merged

[Remote Config] Add Custom Signals#1503
a-maurice merged 6 commits into
mainfrom
am-custom_signals

Conversation

@a-maurice

Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Add support for setting Custom Signals in Remote Config. Note that this depends on firebase/firebase-cpp-sdk#1899


Testing

Describe how you've tested these changes.

Running the tests locally on Android/iOS/Mac.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Feature Request:
#1210

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for setting Custom Signals in Remote Config, including C# API bindings, SWIG interface updates, and corresponding UI and automated test cases. The review feedback highlights two important improvements: first, explicitly disposing of SWIG-wrapped StringList and VariantList objects in SetCustomSignalsAsync to prevent unmanaged memory leaks, along with adding a defensive check against null keys; second, resolving a potential race condition in the automated test by directly awaiting both FetchAsync and ActivateAsync instead of relying on FetchDataAsync which does not await activation.

Comment thread remote_config/src/FirebaseRemoteConfig.cs
@a-maurice
a-maurice requested a review from AustinBenoit August 13, 2026 20:32
@a-maurice
a-maurice merged commit 14ff2f9 into main Aug 18, 2026
14 checks passed
@a-maurice
a-maurice deleted the am-custom_signals branch August 18, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants