Conversation
… in containerCleaner (b/563478852)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the temporary NoopArtifactRegistryCleaner class from src/deploy/functions/containerCleaner.ts, which was previously used to disable Artifact Registry cleaning when it was not yet enabled. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Buganizer b/563478852
Proposed Improvement
Removes the obsolete temporary class
NoopArtifactRegistryCleanerand its outdated comment fromsrc/deploy/functions/containerCleaner.ts. Artifact Registry support in Cloud Functions has long been generally available and enabled across Firebase deployment workflows. This class had zero references or usages across the entire codebase.Verification
git grep "NoopArtifactRegistryCleaner": Verified zero occurrences across the repository.npm run build: TypeScript compilation succeeded without errors.mocha src/deploy/functions/containerCleaner.spec.ts: All 27 unit tests passed cleanly.eslint src/deploy/functions/containerCleaner.ts: Linting passed with 0 errors.