Skip to content

[AI Improvement] [Task] Remove obsolete and unused @types packages from package.json devDependencies - #11117

Draft
joehan wants to merge 1 commit into
mainfrom
ai-improve-563477508-task-remove-obsolete-and-unused-typ
Draft

joehan wants to merge 1 commit into
mainfrom
ai-improve-563477508-task-remove-obsolete-and-unused-typ

Conversation

@joehan

@joehan joehan commented Sep 18, 2026

Copy link
Copy Markdown
Member

Resolves Buganizer b/563477508

Proposed Improvement

Removed obsolete and unused @types/* packages from package.json devDependencies:

  • @types/html-escaper (html-escaper is not installed or used anywhere in src/ or scripts/).
  • @types/inquirer and @types/inquirer-autocomplete-prompt (the CLI previously migrated to @inquirer/prompts in src/prompt.ts, which includes its own built-in type declarations; neither legacy inquirer nor inquirer-autocomplete-prompt are installed dependencies).
  • @types/multer (multer is not installed or used anywhere).

Also updated npm-shrinkwrap.json via npm install --package-lock-only, which cleanly pruned the four type packages and their unreferenced transitive dependency @types/through.

Verification

  • npm run build: TypeScript and MCP app compilation succeeded cleanly.
  • npm run test:compile: Type checking passed with 0 errors.
  • npm run lint:quiet: ESLint and Prettier passed cleanly.
  • mocha src/prompt.spec.ts: All 18 prompt unit tests passed without missing types.

@joehan joehan self-assigned this Sep 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several unused or redundant TypeScript type definition dependencies from package.json, including @types/html-escaper, @types/inquirer, @types/inquirer-autocomplete-prompt, and @types/multer. No review comments were provided, and there is no additional feedback to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants