[AI Improvement] [Task] Remove obsolete and unused @types packages from package.json devDependencies - #11117
Draft
joehan wants to merge 1 commit into
Draft
[AI Improvement] [Task] Remove obsolete and unused @types packages from package.json devDependencies#11117joehan wants to merge 1 commit into
joehan wants to merge 1 commit into
Conversation
…n devDependencies (b/563477508)
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes several unused or redundant TypeScript type definition dependencies from package.json, including @types/html-escaper, @types/inquirer, @types/inquirer-autocomplete-prompt, and @types/multer. No review comments were provided, and there is no additional feedback to address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Buganizer b/563477508
Proposed Improvement
Removed obsolete and unused
@types/*packages frompackage.jsondevDependencies:@types/html-escaper(html-escaperis not installed or used anywhere insrc/orscripts/).@types/inquirerand@types/inquirer-autocomplete-prompt(the CLI previously migrated to@inquirer/promptsinsrc/prompt.ts, which includes its own built-in type declarations; neither legacyinquirernorinquirer-autocomplete-promptare installed dependencies).@types/multer(multeris not installed or used anywhere).Also updated
npm-shrinkwrap.jsonvianpm install --package-lock-only, which cleanly pruned the four type packages and their unreferenced transitive dependency@types/through.Verification
npm run build: TypeScript and MCP app compilation succeeded cleanly.npm run test:compile: Type checking passed with 0 errors.npm run lint:quiet: ESLint and Prettier passed cleanly.mocha src/prompt.spec.ts: All 18 prompt unit tests passed without missing types.