Skip to content

[AI Improvement] [Task] Remove orphaned ambient type definition src/types/extractTriggers.d.ts - #11116

Draft
joehan wants to merge 1 commit into
mainfrom
ai-improve-563478078-task-remove-orphaned-ambient-type-d
Draft

joehan wants to merge 1 commit into
mainfrom
ai-improve-563478078-task-remove-orphaned-ambient-type-d

Conversation

@joehan

@joehan joehan commented Sep 18, 2026

Copy link
Copy Markdown
Member

Resolves Buganizer b/563478078

Proposed Improvement

Deletes the orphaned ambient declaration file src/types/extractTriggers.d.ts. The underlying runtime module (src/deploy/functions/runtimes/node/extractTriggers) was removed during historical Cloud Functions discovery refactoring, and no files in src/ import or reference it. Removing this file eliminates dead declarations from the global TypeScript compilation context.

Verification

  • Verified zero references to extractTriggers remain in src/ (git grep "extractTriggers" src/).
  • npm run build: Passed cleanly with zero TypeScript compilation errors.
  • npm run test:compile: Passed cleanly.
  • npm run lint:quiet: Passed cleanly.
  • Node runtime & functions emulator unit tests: 69 tests passing.

@joehan joehan self-assigned this Sep 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the declaration file for the extractTriggers function, which was used to extract trigger definitions from a function file. There are no review comments, and I have no feedback to provide on these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants