Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes several integration test files and their associated test assets, specifically deleting 'test-functions-deploy.js', 'test-functions-env.js', and the JavaScript files containing the test functions. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Buganizer b/563478113
Proposed Improvement
Deletes obsolete, abandoned integration test scripts from early Cloud Functions development (
scripts/test-functions-deploy.js,scripts/test-functions-env.js) and their supporting fixtures (scripts/assets/functions_to_test.js,scripts/assets/functions_to_test_minimal.js), removing the emptyscripts/assets/directory. Modern functions deploy tests are consolidated underscripts/functions-deploy-tests/.Verification
git grepfor all references; zero remaining references found.npm run buildcompiles cleanly.mocha src/deploy/functions/prepare.spec.ts(91 passing).